+1, binding Comments: * source matched the referenced commit * L&N look good for the additions since 0.4.0 * hashes and signature looked good * build and tests checked out in CentOS, OS X 10.13, and Ubuntu 18.04 driven by bootstrap * verified functionality with some simple flows and Site to Site transfer to NiFi over an extended duration
As a note to other reviewers, the resulting assembly will be located in your build directory as 'nifi-minifi-cpp-0.5.0-bin.tar.gz' Thanks for generating this RC, Jeremy and to all the contributors. A lot of great new bits in this release. --aldrin On Fri, Jun 1, 2018 at 11:41 AM, Marc <phroc...@apache.org> wrote: > Jeremy, > +1 binding > > Thanks for generating the release! > > I verified sigs and checksums. Built on u18 and OSX. > > I ran unit/integration tests with ctest. Also ran a simple flow with > GetFile -> LogAttribute, but also includes two controller services for > battery monitoring and network management. > > Thanks, > Marc > > > On Thu, May 31, 2018 at 8:39 PM, Jeremy Dyer <jeremyd...@apache.org> > wrote: > > Hello Apache NiFi Community, > > > > I am pleased to call this vote for the source release of Apache NiFi > MiNiFi > > C++, nifi-minifi-cpp-0.5.0. > > > > The source archive, signature, and digests can be located at: > > > > Source Archive: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz > > > > GPG armored signature: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.asc > > > > Source MD5: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.md5 > > > > Source SHA1: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.sha1 > > > > Source SHA256: > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > > 0.5.0/nifi-minifi-cpp-0.5.0-source.tar.gz.sha256 > > > > The Git tag is minifi-cpp-0.5.0-RC1 > > The Git commit hash is 5f3b3973e37def4d8ed2753837986d121fd58322 > > * *https://git-wip-us.apache.org/repos/asf?p=nifi-minifi- > cpp.git;a=commit;h=5f3b3973e37def4d8ed2753837986d121fd58322 > > <https://git-wip-us.apache.org/repos/asf?p=nifi-minifi- > cpp.git;a=commit;h=5f3b3973e37def4d8ed2753837986d121fd58322>* > > * *https://github.com/apache/nifi-minifi-cpp/commit/ > 5f3b3973e37def4d8ed2753837986d121fd58322 > > <https://github.com/apache/nifi-minifi-cpp/commit/ > 5f3b3973e37def4d8ed2753837986d121fd58322>* > > > > Checksums of nifi-minifi-cpp-0.5.0-source.tar.gz: > > MD5: 9ec230b9ac3004981000276015860c52 > > SHA1: a9e3fe34ed25f9f1a840cd318845bcdb6fb622f1 > > SHA256: 78b5bbd65d1e3484efafc02a882f99063e06b88e1694daff6c24aaa3066037dc > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/dev/nifi/KEYS > > > > 87 issues were closed/resolved for this release: > > *https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12321520&version=12342659 > > <https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12321520&version=12342659>* > > > > Release note highlights can be found here: > > *https://cwiki.apache.org/confluence/display/MINIFI/ > Release+Notes#ReleaseNotes-Versioncpp-0.5.0 > > <https://cwiki.apache.org/confluence/display/MINIFI/ > Release+Notes#ReleaseNotes-Versioncpp-0.5.0>* > > > > The vote will close 3 June at 9PM EST. > > > > Please download the release candidate and evaluate the necessary items > > including checking hashes, signatures, build from source, and test. Then > > please vote: > > > > [ ] +1 Release this package as nifi-minifi-cpp-0.4.0 > > [ ] +0 no opinion > > [ ] -1 Do not release this package because... > > > > Thanks! >
