+1, non-binding.
Followed the steps in the release helper guide, verified the readme, ran a
simple flow with s2s.
Nice work everyone! Thanks for RM'ing this one Jeremy.
Kevin
On 7/1/18, 14:22, "Tony Kurc" <tk...@apache.org> wrote:
+1 (binding)
License + notice look good
built without issue
hashes and signature look good
Tested using a really simple flow
On Sun, Jul 1, 2018 at 1:42 PM, Jeff <jtsw...@gmail.com> wrote:
> +1, binding
>
> Ran through the release helper guide
> Created a simple flow for MiNiFi in NiFi, used the transform of the MiNiFi
> toolkit to create a config.yml
> Started MiNiFi with the config.yml created by the MiNiFi toolkit
> Observed the results in NiFi, working as expected.
>
> On Fri, Jun 29, 2018 at 6:59 PM Andy LoPresto <alopre...@apache.org>
> wrote:
>
> > +1, binding
> >
> > Verified all keys and checksums, ran through all the builds, verified
> > tests and contrib-check, and the existence of LICENSE/NOTICE/README at
> > appropriate locations. A couple minor points on the release process
below
> > (and some other non-blocking issues that I will open as Jiras).
> >
> > * Now that MD5 is deprecated, I believe we agreed to provide a SHA-512
> > signature as well. The release guide should be updated to include this
> for
> > next time.
> > * The release helper should specify that LICENSE, NOTICE, and README are
> > in minifi-assembly/target*/minifi-0.5.0-bin/minifi-0.5.0/*
> >
> > Andy LoPresto
> > alopre...@apache.org
> > *alopresto.apa...@gmail.com <alopresto.apa...@gmail.com>*
> > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
> >
> > On Jun 29, 2018, at 8:29 AM, Aldrin Piri <aldrinp...@gmail.com> wrote:
> >
> > Hi folks,
> >
> > I worked with Jeremy to resolve the discrepancy and we were able to get
> the
> > commits/tag in question from the Maven release plugin pushed to the
repo.
> >
> > The minifi-0.5.0-RC2 tag is correct in pointing to the source of the...
> > source commit 58b8c598c0866c8f1200164ab14f3df0d632d522 which was
> initiated
> > from the last commit on master, 05f516d3da33a0547ccfad34241450
> 4cdacd4a68.
> >
> > Links for reference:
> > tag:
> > * https://github.com/apache/nifi-minifi/tree/minifi-0.5.0-RC2
> > *
> >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi.git;a=
> shortlog;h=refs/tags/minifi-0.5.0-RC2
> >
> > RC2 branch commit:
> > *
> >
> > https://github.com/apiri/nifi-minifi/commit/
> 58b8c598c0866c8f1200164ab14f3df0d632d522
> > *
> >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi.git;a=commit;h=
> 58b8c598c0866c8f1200164ab14f3df0d632d522
> >
> > --aldrin
> >
> >
> > On Fri, Jun 29, 2018 at 7:59 AM Jeff Zemerick <jzemer...@apache.org>
> > wrote:
> >
> > +1 non-binding
> >
> > Built and ran MiNiFi and C2 without issues.
> >
> > On Thu, Jun 28, 2018 at 3:59 PM Aldrin Piri <ald...@apache.org> wrote:
> >
> > +1, binding
> >
> > comments:
> > My vote is on the assumption there there was a slight mix up with
tagging
> > and it can be easily remedied. The
> > 05f516d3da33a0547ccfad342414504cdacd4a68
> > points to the last commit and a snapshot version. This is correct from
> > where the release is started but does not capture the generated prepared
> > release artifacts. I believe if that is pushed and referenced, we will
> > have what is packed in the source distribution, which is listed as
0.5.0,
> > non-snapshot.
> >
> > signature and hashes looked good
> > verified contrib, build, and tests of minifi, config-toolkit, and c2
> >
> > server
> >
> > verified transform functionality of config toolkit
> > verified consumption of transformed config in minifi and its successful
> > site to site transaction to nifi
> > verified interaction with c2 server with a file based provider
> >
> > On Thu, Jun 28, 2018 at 1:19 PM Jeremy Dyer <jeremyd...@apache.org>
> >
> > wrote:
> >
> >
> > Hello,
> >
> > I am pleased to call this vote for the source release of Apache NiFi
> >
> > MiNiFi
> >
> > minifi-0.5.0 RC2.
> >
> > The source zip, including signatures, digests, etc. can be found at:
> > *
> >
> > https://repository.apache.org/content/repositories/orgapachenifi-1130/
> >
> > <
> >
> > https://repository.apache.org/content/repositories/orgapachenifi-1130/
> >
> > *
> >
> > The Git tag is minifi-0.5.0-RC2
> > The Git commit ID is 05f516d3da33a0547ccfad342414504cdacd4a68
> > *
> >
> >
> >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi.git;a=commit;h=
> 05f516d3da33a0547ccfad342414504cdacd4a68
> >
> > <
> >
> >
> >
> > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi.git;a=commit;h=
> 05f516d3da33a0547ccfad342414504cdacd4a68
> >
> > *
> >
> > *
> >
> >
> >
> > https://github.com/apache/nifi-minifi/commit/
> 05f516d3da33a0547ccfad342414504cdacd4a68
> >
> > <
> >
> >
> >
> > https://github.com/apache/nifi-minifi/commit/
> 05f516d3da33a0547ccfad342414504cdacd4a68
> >
> > *
> >
> >
> > wget
> >
> >
> >
> >
> > https://repository.apache.org/content/repositories/
> orgapachenifi-1130/org/apache/nifi/minifi/minifi/0.5.0/
> minifi-0.5.0-source-release.zip
> >
> >
> > Checksums of minifi-0.5.0-source-release.zip:
> > SHA1: be624db030aedd5c249e58c4c57d55ca917cd6ea
> > SHA256:
> >
> > 1f96ca7d8c2f52f9c15dad532065163f14cb01a2edbc783d4faa33656ff5ab88
> >
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/jeremydyer.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/nifi/KEYS
> >
> > 16 issues were closed/resolved for this release:
> > *
> >
> >
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12319921&version=12342658
> >
> > <
> >
> >
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12319921&version=12342658
> >
> > *
> >
> >
> > Release note highlights can be found here:
> > https://cwiki.apache.org/confluence/display/MINIFI/Release+
> > Notes#ReleaseNotes-Version0.5.0
> >
> > The vote will be open until 2:00PM EDT, 1 July 2018.
> >
> > Please download the release candidate and evaluate the necessary items
> > including checking hashes, signatures, build
> > from source, and test. Then please vote:
> >
> > [ ] +1 Release this package as minifi-0.4.0
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because...
> >
> > Thanks!
> >
> >
> >
> >
> >
>
