Ah, sorry, I misunderstood. You are not the PR author; you want those same comments to be addressed.
Andy LoPresto alopre...@apache.org alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Feb 7, 2019, at 5:16 PM, Andy LoPresto <alopre...@apache.org> wrote: > > Charlie, I see comments from Matt Burgess (especially considering exceptions > & stack traces) from 9 days ago that don’t appear to be addressed. Were you > waiting for additional information? Am I missing something? Thanks. > > > Andy LoPresto > alopre...@apache.org <mailto:alopre...@apache.org> > alopresto.apa...@gmail.com > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > >> On Feb 7, 2019, at 3:24 PM, Charlie Meyer <charlie.me...@civitaslearning.com >> <mailto:charlie.me...@civitaslearning.com>> wrote: >> >> Hoping I am not too late to the party, but it would be fantastic if >> https://github.com/apache/nifi/pull/3253 >> <https://github.com/apache/nifi/pull/3253> could have the comments on it >> addressed and included the 1.9 release >> >> -Charlie >> >> On Wed, Feb 6, 2019 at 9:08 PM Joe Witt <joe.w...@gmail.com >> <mailto:joe.w...@gmail.com>> wrote: >> >>> MarkB - i dont have any issue with that being include but we need to find >>> someone familiar enough with that to review it. If that happens in the >>> next couple days then great. Any takers familiar with JMS and that class? >>> The changes are few but the implications are unclear to me. >>> >>> Thanks >>> >>> On Wed, Feb 6, 2019 at 9:55 PM Mark Bean <mark.o.b...@gmail.com >>> <mailto:mark.o.b...@gmail.com>> wrote: >>> >>>> I have an open PR I'd like included in 1.9. It's a very simple one. >>>> >>>> https://github.com/apache/nifi/pull/3053 >>>> <https://github.com/apache/nifi/pull/3053> >>>> >>>> Thanks, >>>> Mark >>>> >>>> On Wed, Feb 6, 2019 at 7:43 PM Joe Witt <joe.w...@gmail.com> wrote: >>>> >>>>> i have that one ready to go andy. ill take care of the dev docs one. >>>>> >>>>> thanks >>>>> >>>>> On Wed, Feb 6, 2019, 7:24 PM Andy LoPresto <alopre...@apache.org >>> wrote: >>>>> >>>>>> I also want to merge https://github.com/apache/nifi/pull/3283 >>>>>> <https://github.com/apache/nifi/pull/3283> < >>>>>> https://github.com/apache/nifi/pull/3283 >>>>>> <https://github.com/apache/nifi/pull/3283>> so we can get the >>> Developer >>>>>> Guide more visibility in the docs. Will do today. >>>>>> >>>>>> Andy LoPresto >>>>>> alopre...@apache.org <mailto:alopre...@apache.org> >>>>>> alopresto.apa...@gmail.com >>>>>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 >>>>>> >>>>>>> On Feb 7, 2019, at 10:12 AM, Ed B <bdes...@gmail.com> wrote: >>>>>>> >>>>>>> Haha, just using this opportunity to pull attention and get >>> reviewer >>>> :D >>>>>>> >>>>>>> But totally agreed, it's time for 1.9 to be finalized. >>>>>>> >>>>>>> Thanks, >>>>>>> Ed. >>>>>>> >>>>>>> >>>>>>> On Wed, Feb 6, 2019 at 5:08 PM Joe Witt <joe.w...@gmail.com >>>>>>> <mailto:joe.w...@gmail.com>> >>> wrote: >>>>>>> >>>>>>>> Thanks Andy sounds good. >>>>>>>> >>>>>>>> EdB: Sure we just need to find a reviewer. There are tons of good >>>> prs >>>>>> out >>>>>>>> there its just about getting good review cycles/progress. >>>>>>>> >>>>>>>> I'd like to shoot for early next week RC beginning if we can pull >>> it >>>>>> off. >>>>>>>> >>>>>>>> Thanks >>>>>>>> Joe >>>>>>>> >>>>>>>> On Wed, Feb 6, 2019 at 5:07 PM Andy LoPresto < >>>>>> alopresto.apa...@gmail.com <mailto:alopresto.apa...@gmail.com>> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> The PR for adding HTTP headers is complete, I just need to merge >>>> it. >>>>>> Will >>>>>>>>> do today. >>>>>>>>> >>>>>>>>> Andy LoPresto >>>>>>>>> alopre...@apache.org <mailto:alopre...@apache.org> >>>>>>>>> alopresto.apa...@gmail.com >>>>>>>>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D >>> EF69 >>>>>>>>> >>>>>>>>>> On Feb 7, 2019, at 08:23, Ed B <bdes...@gmail.com >>>>>>>>>> <mailto:bdes...@gmail.com>> wrote: >>>>>>>>>> >>>>>>>>>> if not too late, would be nice to have JNDI bug fix included in >>>> new >>>>>>>>> release: >>>>>>>>>> >>>>>>>>>> "JMS Connection Fails After JMS servers Change behind JNDI" >>>>>>>>>> https://issues.apache.org/jira/browse/NIFI-5869 >>>>>>>>>> <https://issues.apache.org/jira/browse/NIFI-5869> >>>>>>>>>> PR is available: >>>>>>>>>> https://github.com/apache/nifi/pull/3261 >>>>>>>>>> >>>>>>>>>> Thank you, >>>>>>>>>> Ed. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On Wed, Feb 6, 2019 at 1:13 PM Joe Witt <joe.w...@gmail.com> >>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> thanks for bumping that peter. Mark P just got it merged. >>>>>>>>>>> >>>>>>>>>>> otherwise I see a few straggling items that look like they need >>>> to >>>>> be >>>>>>>>>>> merged and i'll start the process! Somehow this release has >>>>> sneakily >>>>>>>>>>> become packed with good fixes and improvements. >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> >>>>>>>>>>>> On Wed, Feb 6, 2019 at 10:34 AM Joe Witt <joe.w...@gmail.com >>>>>>>>>>>> <mailto:joe.w...@gmail.com>> >>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> agreed. looks important enough to warrant pulling in and I >>> just >>>>>>>> tagged >>>>>>>>>>> as >>>>>>>>>>>> 1.9.0 fix version to at least force discussion. >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Feb 6, 2019 at 10:30 AM Peter Wicks (pwicks) < >>>>>>>>> pwi...@micron.com <mailto:pwi...@micron.com>> >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> I'd like to see a review of this bug before we release 1.9.0, >>>> as >>>>> it >>>>>>>>>>> helps >>>>>>>>>>>>> mature the Node Offload feature. >>>>>>>>>>>>> >>>>>>>>>>>>> NIFI-5940 Cluster Node Offload Hangs if any RPG on flow is >>>>> Disabled >>>>>>>>>>>>> https://github.com/apache/nifi/pull/3255 >>>>>>>>>>>>> <https://github.com/apache/nifi/pull/3255> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Peter >>>>>>>>>>>>> >>>>>>>>>>>>> -----Original Message----- >>>>>>>>>>>>> From: Joe Witt [mailto:joew...@apache.org] >>>>>>>>>>>>> Sent: Tuesday, February 5, 2019 10:51 AM >>>>>>>>>>>>> To: dev@nifi.apache.org >>>>>>>>>>>>> Subject: [EXT] [discuss] release apache nifi 1.9.0 >>>>>>>>>>>>> >>>>>>>>>>>>> Team, >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>> >>>>> >>>> >>> https://issues.apache.org/jira/browse/NIFI-5995?jql=project%20%3D%20NIFI%20AND%20status%20in%20(Resolved%2C%20%22Patch%20Available%22)%20AND%20fixVersion%20%3D%201.9.0%20ORDER%20BY%20key%20DESC >>> >>> <https://issues.apache.org/jira/browse/NIFI-5995?jql=project%20%3D%20NIFI%20AND%20status%20in%20(Resolved%2C%20%22Patch%20Available%22)%20AND%20fixVersion%20%3D%201.9.0%20ORDER%20BY%20key%20DESC> >>>>>>>>>>>>> >>>>>>>>>>>>> We have a pretty large list of bugs/features added already to >>>>>>>> justify >>>>>>>>> a >>>>>>>>>>>>> 1.9.0 release as well. >>>>>>>>>>>>> >>>>>>>>>>>>> I'm happy to give RM a go again unless there are volunteers >>>>>> strongly >>>>>>>>>>>>> interested. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Joe >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Edward Berezitsky >>>>>>>>>> bdes...@gmail.com >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Edward Berezitsky >>>>>>> bdes...@gmail.com >>>>>> >>>>>> >>>>> >>>> >>> >
