Hey, I found a problem in nifi.sh introduced in NIFI-8123. nifi.sh points to /bin/sh, the above changes added some uses of the declare builtin which isn’t available in all shells (ash, dash), so those commands fail creating some unexpected output at startup, and the new wait functionality won’t work.
Yeah, bash is usually available but the script points to /bin/sh and that’s not always one those — and isn’t on some Ubuntus. I’m inclined to give this a -1 (non-binding) unless I’ve gotten this wrong. -joey > On Feb 7, 2021, at 8:38 PM, Otto Fowler <ottobackwa...@gmail.com> wrote: > > +1 > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /usr/local/Cellar/maven/3.6.3_1/libexec > Java version: 1.8.0_282, vendor: AdoptOpenJDK, runtime: > /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "10.16", arch: "x86_64", family: “mac" > > >> On Feb 7, 2021, at 01:09, Joe Witt <joew...@apache.org> wrote: >> >> Hello, >> >> I am pleased to be calling this vote for the source release of Apache NiFi >> 1.13.0. >> >> The source zip, including signatures, digests, etc. can be found at: >> https://repository.apache.org/content/repositories/orgapachenifi-1177 >> >> The source being voted upon and the convenience binaries can be found at: >> https://dist.apache.org/repos/dist/dev/nifi/nifi-1.13.0/ >> >> A helpful reminder on how the release candidate verification process works: >> https://cwiki.apache.org/confluence/display/NIFI/How+to+help+verify+an+Apache+NiFi+release+candidate >> >> The Git tag is nifi-1.13.0-RC3 >> The Git commit ID is 547127c07aa9da2698b8b6f65e990b986065ef18 >> https://gitbox.apache.org/repos/asf?p=nifi.git;a=commit;h=547127c07aa9da2698b8b6f65e990b986065ef18 >> >> Checksums of nifi-1.13.0-source-release.zip: >> SHA256: 670f6c97a5a2ea488b3006cd6267fa9f02aeeb0d5d011b02f43f76c51ee787bc >> SHA512: >> a9ed5d8b5380bedbb18c94c22ba577901392141ba5f07c0c812e548d88df76a365d99ab7cb890d1803acb2e0f0215c1d6ed9dc4704af1da7e0854ef96fa649ad >> >> Release artifacts are signed with the following key: >> https://people.apache.org/keys/committer/joewitt.asc >> >> KEYS file available here: >> https://dist.apache.org/repos/dist/release/nifi/KEYS >> >> 253 issues were closed/resolved for this release: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12348700 >> >> Release note highlights can be found here: >> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.13.0 >> >> The vote will be open for 72 hours. >> Please download the release candidate and evaluate the necessary items >> including checking hashes, signatures, build from source, and test. Then >> please vote: >> >> [ ] +1 Release this package as nifi-1.13.0 >> [ ] +0 no opinion >> [ ] -1 Do not release this package because... >
