Gonna wait for https://issues.apache.org/jira/browse/NIFI-10857 as this was apparently made bigger and some tests broken from another 1.19 JIRA.
Probably gonna kick out the RC tomorrow and then let the vote run through Monday. Thanks On Fri, Nov 18, 2022 at 9:56 AM Mike Thomsen <mikerthom...@gmail.com> wrote: > Can someone do a quick review on this? I think it would be a nice > little bullet point on our release to say we added preliminary support > for Neo4J 5 since it's so new. > > https://github.com/apache/nifi/pull/6684 > > (Enabling the V5 profile has a hard dependency on Java 17) > > On Fri, Nov 18, 2022 at 11:00 AM Joe Witt <joe.w...@gmail.com> wrote: > > > > Goodness. Some pretty cool collaboration on things like the docker > updates > > and NiFi 1.19 is looking healthy. Time permitting, I'd like to start the > > RC today. > > > > Thanks > > > > On Tue, Nov 15, 2022 at 6:16 PM Kevin Doran <kdo...@apache.org> wrote: > > > > > NIFI-10701 is merged. If folks are ok holding off a day or two more > for > > > 1.19, I'll look into following the work Ferenc Kis did for that to > knock > > > out NIFI-10820. > > > > > > On Nov 15, 2022 at 19:43:57, Matt Burgess <mattyb...@apache.org> > wrote: > > > > > > > Awesome, thanks all! I'd like to wait for Github actions to be happy > > > > and then merge? > > > > > > > > On Tue, Nov 15, 2022 at 7:11 PM Mark Bean <mark.o.b...@gmail.com> > wrote: > > > > > > > > > > > > NIFI-10703 has been worked through. I think it's good to go now. > > > > > > > > > > > > On Tue, Nov 15, 2022 at 4:43 PM Matt Burgess <mattyb...@apache.org> > > > wrote: > > > > > > > > > > > > > I can take that review too, if your suggestions are incorporated. I > > > > > > > > > started looking the other day but didn't get to dig in. I'll try to > > > > > > > > > reproduce in the meantime. > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Matt > > > > > > > > > > > > > > > > > > On Tue, Nov 15, 2022 at 4:42 PM Nathan Gough <thena...@apache.org> > > > > wrote: > > > > > > > > > > > > > > > > > > > > We might also want > https://issues.apache.org/jira/browse/NIFI-10787 > > > > > > > > > > > > > > > > > > > > On Tue, Nov 15, 2022 at 4:05 PM Mark Bean <mark.o.b...@gmail.com > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > I will be on it in about 2 hours, if not addressed sooner. > > > > > > > > > > > > > > > > > > > > > > On Tue, Nov 15, 2022 at 3:46 PM Joe Witt <joe.w...@gmail.com> > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > NIFI-10703 would be great to get in. Just a matter of > gettin' it > > > > > > > > > done > > > > > > > > > > > and > > > > > > > > > > > > merged I think. You're on it? > > > > > > > > > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Nov 15, 2022 at 1:38 PM Mark Bean < > mark.o.b...@gmail.com > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > Sorry.. check that. There's a typo in the latest commit on > that > > > > PR. > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Nov 15, 2022 at 3:35 PM Mark Bean < > > > mark.o.b...@gmail.com > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > Could we get NIFIDEVS-10703 (PR #6638) in there too? > AFAIK, > > > > it's > > > > > > > > > good > > > > > > > > > > > > to > > > > > > > > > > > > > > go. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > Mark > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Nov 15, 2022 at 2:56 PM Joe Witt < > joe.w...@gmail.com > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > >> Hello All, > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> I plan to kick off the RC as soon as > > > > > > > > > > > > > >> https://issues.apache.org/jira/browse/NIFI-10701 is > merged. > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Thanks > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> On Thu, Nov 10, 2022 at 12:52 PM David Handermann < > > > > > > > > > > > > > >> exceptionfact...@apache.org> wrote: > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> > Joe, > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > Thanks for initiating the discussion. I agree with > moving > > > > > > > > > toward a > > > > > > > > > > > > > >> 1.19.0 > > > > > > > > > > > > > >> > release instead of 1.18.1 given over 150 Jira issues > > > already > > > > > > > > > > > tagged > > > > > > > > > > > > > with > > > > > > > > > > > > > >> > 1.19.0. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > We should start another thread soon regarding 2.0. > One of > > > > the > > > > > > > > > key > > > > > > > > > > > > > >> things to > > > > > > > > > > > > > >> > do before that, however, would be to finish adding > > > > deprecation > > > > > > > > > > > > logging > > > > > > > > > > > > > >> to > > > > > > > > > > > > > >> > remaining features we plan to remove in 2.0. Having a > > > minor > > > > > > > > > > > release > > > > > > > > > > > > in > > > > > > > > > > > > > >> > version 1 series deprecating targets for removal > should > > > be a > > > > > > > > > > > > > >> prerequisite > > > > > > > > > > > > > >> > before branching and starting on 2.0. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > In the meantime, if that means we plan on a 1.20.0 > > > release, > > > > I > > > > > > > > > am > > > > > > > > > > > in > > > > > > > > > > > > > >> favor > > > > > > > > > > > > > >> > of moving forward with 1.19.0. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > Regards, > > > > > > > > > > > > > >> > David Handermann > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > On Thu, Nov 10, 2022 at 1:44 PM Joe Witt < > > > > joe.w...@gmail.com> > > > > > > > > > > > > wrote: > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > Team, > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > We keep getting a slew of emails on various lists, > > > slack, > > > > > > > > > and > > > > > > > > > > > the > > > > > > > > > > > > > >> > security > > > > > > > > > > > > > >> > > list about commons text. We need a 1.18.1 or a > 1.19.0. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > Given all that has already happened on 1.19.0 I'm > > > inclined > > > > > > > > > to > > > > > > > > > > > just > > > > > > > > > > > > > 'do > > > > > > > > > > > > > >> > > that' release and get it going. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > I know we need to start getting serious about 2.0 > but > > > > > > > > > perhaps > > > > > > > > > > > the > > > > > > > > > > > > > most > > > > > > > > > > > > > >> > > realistic path for that is we branch and come back > to > > > main > > > > > > > > > after > > > > > > > > > > > > we > > > > > > > > > > > > > >> get > > > > > > > > > > > > > >> > > that figured out. But we need to keep moving > forward in > > > > the > > > > > > > > > > > > > meantime. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > Please share if there is anything we know about on > the > > > > main > > > > > > > > > line > > > > > > > > > > > > > which > > > > > > > > > > > > > >> > > would make doing a 1.19.0 problematic. > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > https://issues.apache.org/jira/projects/NIFI/versions/12352345 > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > Thanks > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
