-1 (subject to change if I've done something goofy)
I find contrib check failures.
[INFO] --- checkstyle:3.2.0:check (check-style) @ nifi-nar-maven-plugin ---
[WARNING] src/main/java/org/apache/nifi/NarMojo.java:[29,8] (imports)
UnusedImports: Unused import -
org.apache.maven.artifact.repository.RepositoryRequest.
[WARNING] src/main/java/org/apache/nifi/NarMojo.java:[30,8] (imports)
UnusedImports: Unused import -
org.apache.maven.artifact.resolver.ArtifactNotFoundException.
[WARNING] src/main/java/org/apache/nifi/NarMojo.java:[31,8] (imports)
UnusedImports: Unused import -
org.apache.maven.artifact.resolver.ArtifactResolutionException.
[WARNING] src/main/java/org/apache/nifi/NarMojo.java:[984,17] (blocks)
LeftCurly: '{' at column 17 should be on the previous line.
[WARNING]
src/test/java/org/apache/nifi/extension/definition/extraction/ExtensionClassLoaderFactoryTest.java:[127]
(regexp) RegexpSinglelineJava: Line has trailing whitespace.
After actually removing/changing the mentioned lines it works as expected.
Thanks
Joe
On Mon, Mar 13, 2023 at 12:57 PM Kevin Doran <[email protected]> wrote:
>
> Edit: I meant to say that due to the narrow scope of this release and the
> fact that it is currently blocking release of Apache NiFi 1.21.0, this vote
> will be open for 24 hours as opposed to the normal 72 hours.
>
> On Mar 13, 2023 at 15:56:22, Kevin Doran <[email protected]> wrote:
>
> > Hello Apache NiFi Community,
> >
> > I am pleased to be calling this vote for the source release of Apache NiFi
> > NAR Maven Plugin 1.5.0.
> >
> > The source being voted upon, including signatures, digests, etc. can be
> > found at:
> > https://repository.apache.org/content/repositories/orgapachenifi-1221/org/apache/nifi/nifi-nar-maven-plugin/1.5.0/
> >
> > The Git tag is nifi-nar-maven-plugin-1.5.0-RC1
> > The Git commit ID is ec2635b0474994861d3225538168e46638c0d2bb
> > https://gitbox.apache.org/repos/asf?p=nifi-maven.git;a=commit;h=09d7bb9ff679d0eed9feaa066d2cbdd347a20204
> >
> > Checksum of nifi-nar-maven-plugin-1.5.0-source-release.zip:
> >
> > SHA512:
> > f4b5ab2286319bd53ce5d872008667f63804ca77640e89e15759ffa26743b6854d642a8dec7784fbfc32fcccdfeb7b6b9a3c4daa00886d5d13161b1c2ed47c7f
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/kdoran.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/nifi/KEYS
> >
> > 3 issues were closed/resolved for this release:
> > https://issues.apache.org/jira/projects/NIFI/versions/12352895
> >
> > Release note highlights can be found here:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12352895
> >
> > The vote will be open for 72 hours. Please download the release candidate
> > and evaluate the necessary items including checking hashes, signatures,
> > build from source, and test. Then please vote:
> >
> > [ ] +1 Release this package as nifi-nar-maven-plugin-1.5.0
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because ...
> >
> >