+1 binding. Was able to do full build on a linux system. Hashes/sigs check out.
The L&N look good with basic spot check. The Notice needs to be updated to reflect the 2023 copyright year. Thanks! On Fri, Apr 14, 2023 at 9:59 AM Marton Szasz <sza...@apache.org> wrote: > +1 (binding) > The package, hashes, signatures, etc were all good. Release helper > guide for future reference: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173087303 > > Tested compilation on Ubuntu 22.04 with both GCC and Clang. Tested > both the self-built and the convenience binaries in a log collection > use case, forwarding messages via HTTP to NiFi. > Tested compilation on Windows x64, and a security event log collection > use case using ConsumeWindowsEventLog, and forwarding via > PutUDP/ListenUDP to NiFi. > > Thank you for preparing the RC! > > Marton > > On Fri, 14 Apr 2023 at 18:55, Ferenc Gerlits <fgerl...@apache.org> wrote: > > > > +1 (non-binding) > > > > Verified signatures and hashes, compared the source to the git tag. > > Built from source on Ubuntu Linux 22.04 and Windows. > > Ran the convenience binary on Ubuntu Linux 22.04 with a simple > > ConsumeJournald -> PublishKafka flow. > > Installed and ran the binary built from the source on Windows with a > > simple ConsumeWindowsEventLog -> PublishKafka flow. > > Everything worked fine. > > > > Thanks, > > Ferenc >
