The DockerImage.txt file isn't always updated in the repo, a bit like the README for Docker Hub - it probably should be, but is often forgotten (same for all of the convenience images built after a release). Indeed, this is currently set to 1.15.1 on `main`, but the images in Docker Hub since then have certainly not used an incorrect version.
Nifi 1.16.0 [1] updated the DockerBuild.sh script to allow easier specification of the NIFI_IMAGE_VERSION from the command line. A small issue has just been spotted with this script's use of the text file to obtain the version's default value too [4]. Before then, I think the process was for someone (with access to push images to Docker Hub) to change the text file locally, build & push the image, but not always then raise a PR to update the text file. To manually build the Docker Image locally containing the correct version of the downloaded convenience binary from the Apache servers, simply recreate the `docker build` command from within the DockerBuild.sh [2] file, substituting the correct values for the `--build-arg`s. Alternatively, run the dockermaven [3] build for the repo (having checked out the correct tag from GitHub), enabling the `-P docker` profile as you do so in your `mvn` command. Note, however, that there were differences between the dockermaven and dockerhub builds (both the included script files and the Dockerfile structure) that weren't rationalised until NiFi 1.16.0+. [1]: https://github.com/apache/nifi/blob/rel/nifi-1.16.0/nifi-docker/dockerhub/DockerBuild.sh [2]: https://github.com/apache/nifi/blob/rel/nifi-1.13.2/nifi-docker/dockerhub/DockerBuild.sh#L36 [3]: https://github.com/apache/nifi/tree/rel/nifi-1.16.0/nifi-docker/dockermaven [4]: https://apachenifi.slack.com/archives/CDGMCSDJT/p1686135561932289?thread_ts=1686135561.932289&cid=CDGMCSDJT On Thu, 8 Jun 2023, 00:10 Russell Bateman, <r...@windofkeltia.com> wrote: > I'm re-rolling in order to update the Java inside to 11 in order to > permit using the new Java HTTP client. This seems to work well; I fixed > the bug locally. > > Maybe too old to be important, but NiFi 1.14.0 is a quantum step up for > several aspects of processor writing requiring refactoring. So, until we > can shed the old NAR we cannot rebuild, we're stuck at NiFi 1.13.2. > > > On 6/7/23 15:31, Russell Bateman wrote: > > I downloaded sources to 1.13.2 in order to hand-spin my own container > > image. When I got down to > > /nifi-1.13.2/nifi-docker/dockerhub/Dockerfile/, I found: > > > > ... > > ARG NIFI_VERSION=1.13.1 > > ... > > > > and the version is also wrong in /DockerImage.txt/ which > > /DockerBuild.sh/ consumes. > > > > Indeed, the image that is built appears to be versioned 1.13.1 and not > > 1.13.2 when listing local Docker repository images: > > > > *REPOSITORY TAG IMAGE ID CREATED SIZE* > > apache/nifi 1.13.1 8c18038f152a 30 minutes ago 2.06GB > > > > Why am I juggling so ancient a version? Because I have custom > > processors that cannot be rebuilt (source-code gone) and will not run > > on 1.14.0 and later. > > > > Russ >
