Mike, Thanks for raising the question. Following Matt's comments, I recommend minimizing use of Java 17 features to make it easier to backport changes for now.
Incremental adjustments can be done when backporting, but it requires the author and reviewer to pay careful attention since the GitHub automated builds for the main branch run on Java 17. As Matt recommended, the alternative is to provide separate pull requests for the main and support branches. We already have a few Java 11 and 17 references on the main branch for things like List.of(), and most of these are easy to adjust when backporting, but they do require careful attention. Regards, David Handermann On Mon, Aug 7, 2023 at 4:04 PM Matt Burgess <mattyb...@apache.org> wrote: > In my opinion that's ok, but I think it would be helpful if a PR is > going to be backported to support/nifi-1.x that the PR author provides > two PRs, one against main with Java 17 features and one against > support/nifi-1.x with Java 8 features. That being said, allowing Java > 17 features may make maintenance tougher while there's an active 1.x > branch. Maybe we should wait until we only support NiFi 2.x? > > On Mon, Aug 7, 2023 at 4:59 PM Mike Thomsen <mikerthom...@gmail.com> > wrote: > > > > Since we're standardizing on 17, we're free and clear to use Java 17 > > features, right? >
