Hi Team, In light of the issues found on the MacOS platform I am canceling RC3 and will create RC4 once the issues are resolved.
Two of the runtime issues have already been addressed by these 2 PRs: https://github.com/apache/nifi-minifi-cpp/pull/1782 https://github.com/apache/nifi-minifi-cpp/pull/1783 The investigation of the build issues on the latest MacOS version is still ongoing. @Joe can you confirm that your build issue is on the MacOS version 14.4.1 with xcode 15.3 or that it is due to the flex issue Adam mentioned? Otherwise please share the issue so we could check that one out as well. Thanks, Gabor On Wed, 8 May 2024 at 15:40, Adam Debreceni <adebrec...@apache.org> wrote: > -1 (non-binding) > > Verified signatures/hashes, compiled on macos 14.2.1 with xcode 15.1 and > deployed simple flow through c2 protocol, > but I have found the following on macos: > - getting errors running nifi python processors, due to python searching > for minifi_native.so > - minifi.plist is missing from the package making it impossible to > install the agent as a service > > (We also have to be mindful about the flex package as either we use the > system flex or the brew flex > but for the latter both the PATH and the CMAKE_CXX_FLAGS should be set > accordingly) > > We also found that it does not compile on the newest macos 14.4.1 with > xcode 15.3. > > On Wed, May 8, 2024 at 1:15 PM Martin Zink <martinz...@apache.org> wrote: > > > +1 (non-binding) > > > > -Verified signature, hashes and git commit hash > > -Built it from source with default extensions on RockyLinux 9 (aarch64 > > and x86_64), macOS 14.3.1 (M1) and Windows 10 (x86_64) using the new > > python based bootstrap > > -Ran through a couple of C2 initiated flows > > > > Everything worked as expected, > > > > > > thanks Gabor for RMing great work, > > Martin > > > > > > On Wed, May 8, 2024 at 9:18 AM Gábor Gyimesi <lordga...@apache.org> > wrote: > > > > > > Hi Joe, > > > > > > Could you check the ninja output for the build error? The output you > sent > > > is only the bootstrap script's traceback of the build step's failure, > but > > > there should probably be an error in the build output as well starting > > with > > > "error: ". > > > > > > BR, > > > Gabor > > > > > > On Wed, 8 May 2024 at 02:26, Joe Witt <joe.w...@gmail.com> wrote: > > > > > > > Hello > > > > > > > > Sigs/Hashes are good. > > > > > > > > Building source on macos I'm getting a build failure. The only > option > > > > selected was to skip tests otherwise left as defaults. Am following > > the > > > > readme and release guide. > > > > > > > > ninja: build stopped: subcommand failed. > > > > Build was unsuccessful > > > > Traceback (most recent call last): > > > > File > > > > > > > > > > > "/Users/joe/development/build-verify/buld/nifi-minifi-cpp-0.99.0-source/bootstrap/main.py", > > > > line 62, in <module> > > > > main_menu(minifi_options, package_manager) > > > > File > > > > > > > > > > > "/Users/joe/development/build-verify/buld/nifi-minifi-cpp-0.99.0-source/bootstrap/cli.py", > > > > line 87, in main_menu > > > > done = > > main_menu_options[main_menu_prompt["sub_menu"]](minifi_options, > > > > package_manager) > > > > > > > > > > > > > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > File > > > > > > > > > > > "/Users/joe/development/build-verify/buld/nifi-minifi-cpp-0.99.0-source/bootstrap/cli.py", > > > > line 60, in do_one_click_build > > > > assert do_build(minifi_options, package_manager) > > > > > > > > > > > > So then I select to not use ninja and run the one click build again. > > > > It seems to run for much longer then the same output prints again. > > > > > > > > Thanks > > > > Joe > > > > > > > > On Tue, May 7, 2024 at 9:45 AM Arpad Boda <ab...@apache.org> wrote: > > > > > > > > > +1 (binding) > > > > > > > > > > Built on ubuntu, verified signature and checksums. All tests > passed, > > > > > started and ran a simple flow with no issues. > > > > > > > > > > Nice job, team! > > > > > > > > > > On Tue, May 7, 2024 at 11:35 AM Gábor Gyimesi < > lordga...@apache.org> > > > > > wrote: > > > > > > > > > > > Hello, > > > > > > > > > > > > I am pleased to be calling this vote for the source release of > > Apache > > > > > NiFi > > > > > > MiNiFi C++ 0.99.0. > > > > > > > > > > > > The source tarball, some binary builds, plus signatures and > > digests can > > > > > be > > > > > > found at: > > > > > > > > https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/0.99.0/ > > > > > > > > > > > > The Git tag is minifi-cpp-0.99.0-RC3 > > > > > > The Git commit ID is d3d205f3c8a8376bbad4c8a47758d585d57c653b > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=d3d205f3c8a8376bbad4c8a47758d585d57c653b > > > > > > > > > > > > Checksums of nifi-minifi-cpp-0.99.0-source.tar.gz: > > > > > > SHA256: > > > > c00ff309776720b295cb52ab12c1c3d11182af4f19ed0a379d58f96b16841059 > > > > > > SHA512: > > > > > > > > > > > > > > > > > > > > > > > > d1eda2c19da8f0e073cf460bf889c8b4a1b893de4b245dc0147d1c79545d5298c74bedf585afd7091dc9474c923fc2a7075a81a6397bedce310e5838e3afa898 > > > > > > > > > > > > Release artifacts are signed with the following key: > > > > > > https://people.apache.org/keys/committer/lordgamez.asc > > > > > > > > > > > > A helpful reminder on how the release candidate verification > > process > > > > > works: > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173087303 > > > > > > > > > > > > KEYS file available here: > > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS > > > > > > > > > > > > 121 issues were closed/resolved for this release: > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321520&version=12353618 > > > > > > > > > > > > Release note highlights can be found here: > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65145325#ReleaseNotesMiNiFi(C++)-Versioncpp-0.99.0 > > > > > > > > > > > > The vote will be open for 72 hours. > > > > > > Please download the release candidate and evaluate the necessary > > items > > > > > > including checking hashes, signatures, build > > > > > > from source, and test. Then please vote: > > > > > > > > > > > > [ ] +1 Release this package as nifi-minifi-cpp-0.99.0 > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > > > > > > > > >
