+1 (non-binding)

Went through the helper guide, local maven repo cleaned up, full clean
build with contrib check, verified signatures and hashes

Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /Users/fkis/.sdkman/candidates/maven/current
Java version: 21.0.3, vendor: Azul Systems, Inc., runtime:
/Users/fkis/.sdkman/candidates/java/21.0.3-zulu/zulu-21.jdk/Contents/Home
Default locale: en_HU, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"

Validations performed:
- Started NiFi, created a simple flow with ListenHTTP and Input Port.
Validated ListenHTTP processor is able to receive data
- Started MiNiFi Java:
  * created a simple GenerateFlowFile -> InvokeHttp flow and
GenerateFlowFile -> RemoteProcessGroup flow and pushed to MiNiFi via C2
protocol
  * Validated that connectivity between NiFi and MiNiFi works via both
InvokeHTTP and S2S
- NIFI-13395 Add python processors to MiNiFi: included Python processors
from the extension repo. Processors were included in the manifest
- NIFI-13396 Include python processors' allowable values in manifest:
values were correctly sent via the manifest
- NIFI-13242 Sync Resource command: synced (added and deleted) several
resources with C2 server - both asset and extension type
- NIFI-13450 Regenerate MiNiFi Agent Manifest between Heartbeats: manifest
is refreshed for each heartbeat correctly
- NIFI-13407 Sensible defaults for Manifest Id and Runtime Type in MiNiFi
bootstrap: parameters now got sensible values instead of empty string

Thanks for RMing David!

Regards
Ferenc

On Sat, Jun 29, 2024 at 10:02 PM Csaba Bejan <[email protected]> wrote:

> +1 (binding)
>
>    - Went through the helper guide and did a clean build
>    - Verified signatures and hashes
>    - Built on OSX 14.2.1
>    - Java version: Zulu21.28+85-CA (build 21+35)
>    - Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
>    - Started NiFi and created a simple flow, everything looks good
>    - Started MiNiFi and verified integration with C2 Server. Played around
>    with the C2 protocol
>
> Also verified:
>
>    - NIFI-13407 Sensible defaults for Manifest Id and Runtime Type in
>    MiNiFi bootstrap
>    - NIFI-13450 Regenerate MiNiFi Agent Manifest between Heartbeats
>    - It is not a release blocker just wanted to note that if c2 is enabled
>       as manifest is regenerated for each HB at every HB I'm getting
> warnings
>       which can be quite noisy
>       2024-06-29 15:37:34,920 WARN [pool-16-thread-1]
>       o.a.n.m.StandardRuntimeManifestService There is no extension
> manifest for
>       bundle [org.apache.nifi:python-extensions:unversioned]
>       2024-06-29 15:37:34,921 WARN [pool-16-thread-1]
>       o.a.n.m.StandardRuntimeManifestService There is no extension
> manifest for
>       bundle [default:system:unversioned]
>    - NIFI-13436 Retain queue for non-modified connections during MiNiFi
>    flow update
>    - NIFI-13309 Lookup compatible bundles even if previous flow was empty
>    - NIFI-13395 Add python processors to MiNiFi
>       - Python processors are showing up under minifi now when enabled and
>       dropped in the extension directory
>
> Thanks for RMing, David!
>
> Regards,
>
> Csaba
>
> On Sat, Jun 29, 2024 at 11:30 AM Joe Witt <[email protected]> wrote:
>
> > +1 binding
> >
> > full clean build w contrib
> > full suite of integration tests including python/etc..  (see below)
> > built docker image and deployed over an existing set of volumes showing
> > upgrades well from previous releases
> > updated release notes a bit to focus more on end user perspective
> >
> > Test error during integration tests suggesting potentially unstable test.
> > Ran fine on second try
> > [ERROR] Tests run: 33, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> > 0.657 s <<< FAILURE! -- in
> > org.apache.nifi.processors.standard.util.TestServerSFTPTransfer
> > [ERROR]
> >
> >
> org.apache.nifi.processors.standard.util.TestServerSFTPTransfer.testGetListingWithBatchSize
> > -- Time elapsed: 0.019 s <<< ERROR!
> > org.apache.nifi.processors.standard.socket.ClientConnectException: SSH
> > Client connection failed [127.0.0.1:51893]
> > at
> >
> >
> org.apache.nifi.processors.standard.ssh.StandardSSHClientProvider.getClient(StandardSSHClientProvider.java:116)
> > at
> >
> >
> org.apache.nifi.processors.standard.util.SFTPTransfer.getSFTPClient(SFTPTransfer.java:631)
> > at
> >
> >
> org.apache.nifi.processors.standard.util.SFTPTransfer.getListing(SFTPTransfer.java:327)
> > at
> >
> >
> org.apache.nifi.processors.standard.util.SFTPTransfer.getListing(SFTPTransfer.java:289)
> > at
> >
> >
> org.apache.nifi.processors.standard.util.TestServerSFTPTransfer.testGetListingWithBatchSize(TestServerSFTPTransfer.java:225)
> > at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
> > at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
> > Caused by: net.schmizz.sshj.transport.TransportException: Timeout
> expired:
> > 30000 MILLISECONDS
> > at
> >
> >
> net.schmizz.sshj.transport.TransportException$1.chain(TransportException.java:33)
> > at
> >
> >
> net.schmizz.sshj.transport.TransportException$1.chain(TransportException.java:27)
> > at net.schmizz.concurrent.Promise.retrieve(Promise.java:139)
> > at net.schmizz.concurrent.Event.await(Event.java:105)
> > at
> >
> net.schmizz.sshj.transport.KeyExchanger.waitForDone(KeyExchanger.java:172)
> > at
> net.schmizz.sshj.transport.KeyExchanger.startKex(KeyExchanger.java:160)
> > at net.schmizz.sshj.transport.TransportImpl.doKex(TransportImpl.java:254)
> > at net.schmizz.sshj.SSHClient.doKex(SSHClient.java:824)
> > at net.schmizz.sshj.SSHClient.onConnect(SSHClient.java:812)
> > at net.schmizz.sshj.SocketClient.connect(SocketClient.java:69)
> > at
> >
> >
> org.apache.nifi.processors.standard.ssh.StandardSSHClientProvider.getClient(StandardSSHClientProvider.java:113)
> > ... 7 more
> > Caused by: java.util.concurrent.TimeoutException: Timeout expired: 30000
> > MILLISECONDS
> > ... 16 more
> >
> > On Sat, Jun 29, 2024 at 7:01 AM Pierre Villard <
> > [email protected]>
> > wrote:
> >
> > > +1, binding
> > >
> > > Went through the usual steps, deployed a 3-nodes secured cluster in GCP
> > > with NiFi Registry and confirmed everything is working as expected.
> > >
> > > Thanks for taking care of this release David!
> > >
> > > Pierre
> > >
> > > Le ven. 28 juin 2024 à 22:22, Dan S <[email protected]> a écrit :
> > >
> > > > +1 (non-binding)
> > > > Ran through Release Candidate Verification
> > > > Verified signatures and hashes
> > > > Built with:
> > > >
> > > > Maven home: /opt/apache-maven-3.9.6
> > > > Java version: 21.0.3, vendor: Red Hat, Inc., runtime:
> > > > /usr/lib/jvm/java-21-openjdk-21.0.3.0.9-1.el8.x86_64
> > > > Default locale: en_US, platform encoding: UTF-8
> > > > OS name: "linux", version: "4.18.0-513.24.1.el8_9.x86_64", arch:
> > "amd64",
> > > > family: "unix"
> > > >
> > > > Exercised new feature NIFI-13304 SplitExcel
> > > > Discovered bug NIFI-13466
> > > > <https://issues.apache.org/jira/browse/NIFI-13466> and
> > > > created task to research NIFI-13467
> > > > <https://issues.apache.org/jira/browse/NIFI-13467>
> > > >
> > > > Thanks for RM'ing David and all your hard work to get to this point!
> > > >
> > > > On Fri, Jun 28, 2024 at 1:16 PM Matt Burgess <[email protected]>
> > > wrote:
> > > >
> > > > > +1 (binding) Ran through release helper and tried various flows,
> > > verified
> > > > > versioning against a NiFi Registry (not the Git-backed one)
> > > > >
> > > > > Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> > > > > Java version: 21, vendor: Oracle Corporation, runtime:
> > > > > /Users/mburgess/.sdkman/candidates/java/21-oracle
> > > > > Default locale: en_US, platform encoding: UTF-8
> > > > > OS name: "mac os x", version: "14.5", arch: "aarch64", family:
> "mac"
> > > > >
> > > > > Thanks for RM'ing David!
> > > > >
> > > > > On Fri, Jun 28, 2024 at 9:40 AM David Handermann <
> > > > > [email protected]> wrote:
> > > > >
> > > > > > Team,
> > > > > >
> > > > > > I am pleased to be calling this vote for the source release of
> > Apache
> > > > > > NiFi 2.0.0-M4.
> > > > > >
> > > > > > Please review the following guide for how to verify a release
> > > candidate
> > > > > > build:
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/NIFI/Release+Candidate+Verification
> > > > > >
> > > > > > The source being voted on the and the convenience binaries are
> > > > > > available on the Apache Distribution Repository:
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/dev/nifi/nifi-2.0.0-M4
> > > > > >
> > > > > > The build artifacts are available on the Apache Nexus Repository:
> > > > > >
> > > > > >
> > > https://repository.apache.org/content/repositories/orgapachenifi-1275
> > > > > >
> > > > > > Git Tag: nifi-2.0.0-M4-RC1
> > > > > > Git Commit ID: 19c5be01d463bc38ec0f5008549a2a42e589436d
> > > > > > GitHub Commit Link:
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/nifi/commit/19c5be01d463bc38ec0f5008549a2a42e589436d
> > > > > >
> > > > > > Checksums of nifi-2.0.0-M4-source-release.zip
> > > > > >
> > > > > > SHA256:
> > > > d882f05cec09ee1bfafaa3d4cde8f8660512d09765b5c400471f3a6e014029a6
> > > > > > SHA512:
> > > > > >
> > > > >
> > > >
> > >
> >
> d429cd67fb0b7d9737c59cb834106d7b6e25cbdb91e3ecc5290be865a1313cbebbc314c2e0e54228226f021c44f0a86c745a18c148247c632a739c871c5fa013
> > > > > >
> > > > > > Release artifacts are signed with the following key:
> > > > > >
> > > > > > https://people.apache.org/keys/committer/exceptionfactory.asc
> > > > > >
> > > > > > KEYS file is available on the Apache Distribution Repository:
> > > > > >
> > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS
> > > > > >
> > > > > > Issues resolved for this version: 153
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12354678
> > > > > >
> > > > > > Release note highlights can be found on the project wiki:
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version2.0.0-M4
> > > > > >
> > > > > > The vote will be open for 72 hours.
> > > > > >
> > > > > > Please download the release candidate and evaluate the necessary
> > > items
> > > > > > including checking hashes, signatures, build from source, and
> test.
> > > > > > Then please vote:
> > > > > >
> > > > > > [] +1 Release this package as nifi-2.0.0-M4
> > > > > > [] +0 no opinion
> > > > > > [] -1 Do not release this package because...
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to