-1. I'm seeing something that appears to be related to NIFI-144[1]. These
are the test failure I'm getting:
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.nifi.cluster.event.impl.EventManagerImplTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec -
in org.apache.nifi.cluster.event.impl.EventManagerImplTest
Running
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
Tests run: 8, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.389 sec
<<< FAILURE! - in
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest
testIsPermissibleWithMalformedData(org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest)
Time elapsed: 0.032 sec <<< FAILURE!
java.lang.AssertionError: firewall allowed host 'abc' rather than rejecting
as malformed. If `host abc` works locally, this test should have been
skipped.
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest.testIsPermissibleWithMalformedData(FileBasedClusterNodeFirewallTest.java:115)
ensureBadDataWasIgnored(org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest)
Time elapsed: 0.003 sec <<< FAILURE!
java.lang.AssertionError: firewall treated our malformed data as a host. If
`host "bad data should be skipped"` works locally, this test should have
been skipped.
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at
org.apache.nifi.cluster.firewall.impl.FileBasedClusterNodeFirewallTest.ensureBadDataWasIgnored(FileBasedClusterNodeFirewallTest.java:82)
Running org.apache.nifi.cluster.flow.impl.DataFlowManagementServiceImplTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.578 sec -
in org.apache.nifi.cluster.flow.impl.DataFlowManagementServiceImplTest
Running org.apache.nifi.cluster.manager.impl.HttpRequestReplicatorImplTest
Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.584 sec
- in org.apache.nifi.cluster.manager.impl.HttpRequestReplicatorImplTest
Running org.apache.nifi.cluster.manager.impl.HttpResponseMapperImplTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec -
in org.apache.nifi.cluster.manager.impl.HttpResponseMapperImplTest
Running org.apache.nifi.cluster.manager.impl.TestWebClusterManager
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec -
in org.apache.nifi.cluster.manager.impl.TestWebClusterManager
Results :
Failed tests:
FileBasedClusterNodeFirewallTest.ensureBadDataWasIgnored:82 firewall
treated our malformed data as a host. If `host "bad data should be
skipped"` works locally, this test should have been skipped.
FileBasedClusterNodeFirewallTest.testIsPermissibleWithMalformedData:115
firewall allowed host 'abc' rather than rejecting as malformed. If `host
abc` works locally, this test should have been skipped.
Tests run: 41, Failures: 2, Errors: 0, Skipped: 0
When i run the "host" commands suggested in the failure messages, I get:
BRANDONs-MacBook-Pro:nifi-0.1.0-incubating brandon$ host abc
abc has address 92.242.140.21
Host abc not found: 3(NXDOMAIN)
BRANDONs-MacBook-Pro:nifi-0.1.0-incubating brandon$ host "bad data should
be skipped"
bad\032data\032should\032be\032skipped has address 92.242.140.21
Host bad\032data\032should\032be\032skipped not found: 3(NXDOMAIN)
[1] https://issues.apache.org/jira/browse/NIFI-144
Brandon
On Fri, May 8, 2015 at 3:15 PM Joe Witt <[email protected]> wrote:
> All,
>
> I am still a +1 but do want to mention I've seen regressions in two places:
> 1) The nifi.properties file has an extra line break in it for
> provenance attributes.
> 2) The provenance repo leaves files around and the lucene indexing
> seems to lose sync.
>
> I think the release should still go through but I'd recommend we not
> put convenience binaries up. Once the release is done and we've
> validated the patches Mark just put forth we can discuss doing an
> 0.1.1. There are a couple really cool PRs out there too though
> including Joey's Flume processors, Tim's Mongo processors, etc..
> Those would require a bump to 0.2.0 presumably so maybe we'll focus
> purely on bug fixes/docs in 0.1.1 and get that out right away.
>
> Still a +1 just food for thought.
>
> Thanks
> Joe
>
> On Wed, May 6, 2015 at 10:55 PM, Bryan Bende <[email protected]> wrote:
> > +1 (non-binding) Followed all the steps Joe outlined with the same
> results.
> >
> > <Dancing in the street>
> >
> > On Wed, May 6, 2015 at 3:25 PM, Matt Gilman <[email protected]>
> wrote:
> >
> >> +1 Release this package as nifi-0.1.0-incubating
> >>
> >> Looks good!
> >>
> >> On Wed, May 6, 2015 at 1:35 PM, Mark Payne <[email protected]>
> wrote:
> >>
> >> > Hello
> >> >
> >> > I am pleased to be calling this vote for the source release of Apache
> >> NiFi
> >> > nifi-0.1.0-incubating.
> >> >
> >> > In this release, we factored out a parent maven artifact. This means
> that
> >> > we also had to do a new
> >> > release of the nifi-nar-maven-plugin, so there are a total of three
> >> > artifacts for this build:
> >> >
> >> > nifi-parent
> >> > nifi-nar-maven-plugin
> >> > nifi
> >> >
> >> > -----------------------
> >> > For nifi-parent:
> >> >
> >> > The source zip, including signatures, digests, etc. can be found at:
> >> > https://repository.apache.org/content/repositories/orgapachenifi-1046
> >> >
> >> >
> >> > The Git tag is nifi-parent-1.0.0-incubating-rc12
> >> > The Git commit ID is a90c110f6ecfccdd9b460acc09063e3437d3c3b4
> >> >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=a90c110f6ecfccdd9b460acc09063e3437d3c3b4
> >> >
> >> >
> >> > Checksums of nifi-parent-1.0.0-incubating-source-release.zip:
> >> > MD5: fbcfbc6aedb18dfa5a51029a3bf6ddf6
> >> > SHA1: 579e670b9f9c5afa0aedf242c6aca5e1e92914e9
> >> >
> >> > -----------------------
> >> > For nifi-nar-mven-plugin:
> >> >
> >> > The source zip, including signatures, digests, etc. can be found at:
> >> > https://repository.apache.org/content/repositories/orgapachenifi-1047
> >> >
> >> >
> >> > The Git tag is nifi-nar-maven-plugin-1.0.1-incubating-rc12
> >> > The Git commit ID is 753b1f53796150a1cf6c4b1d75dbdd0b15d1d0e6
> >> >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=753b1f53796150a1cf6c4b1d75dbdd0b15d1d0e6
> >> >
> >> >
> >> > Checksums of
> nifi-nar-maven-plugin-1.0.1-incubating-source-release.zip:
> >> > MD5: 3878c30501c3a0aeef0b7e958248c2e2
> >> > SHA1: 29e1e1144b75081828229a864a5842a4f657baa2
> >> >
> >> > -----------------------
> >> > For nifi:
> >> >
> >> > The source zip, including signatures, digests, etc. can be found at:
> >> > https://repository.apache.org/content/repositories/orgapachenifi-1048
> >> >
> >> >
> >> > The Git tag is nifi-0.1.0-incubating-rc12
> >> > The Git commit ID is 76e70003077f84d5a44d1f9950df7aedb201fd48
> >> >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=76e70003077f84d5a44d1f9950df7aedb201fd48
> >> >
> >> >
> >> > Checksums of nifi-0.1.0-incubating-source-release.zip:
> >> > MD5: b6bcc3d84869ec024bd36f9309b44a9b
> >> > SHA1: 24b02b439f9b92e0fe2010e5829c3c88221c0134
> >> >
> >> > -----------------------
> >> > For all artifacts:
> >> >
> >> > Release artifacts are signed with the following key:
> >> > https://people.apache.org/keys/committer/markap14.asc
> >> >
> >> > KEYS file available here:
> >> > https://dist.apache.org/repos/dist/release/incubator/nifi/KEYS
> >> >
> >> >
> >> > Should the source release be successful we intend to make convenience
> >> > binaries available. The
> >> > convenience binary of this source release along with the appropriate
> >> > hashes and signature can be found
> >> > here: https://dist.apache.org/repos/dist/dev/incubator/nifi
> >> >
> >> >
> >> > 115 issues were closed/resolved for this release:
> >> >
> >> >
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12329276
> >> >
> >> >
> >> > The vote will be open for 72 hours.
> >> > Please download the release candidate and evaluate the necessary items
> >> > including checking hashes, signatures, build from source, and test.
> The
> >> > please vote:
> >> >
> >> >
> >> > [ ] +1 Release this package as nifi-0.0.1-incubating
> >> > [ ] +0 no opinion
> >> > [ ] -1 Do not release this package because...
> >> >
> >> >
> >>
>
