+1 (binding); the releases look fine (L&N, incubator disclaimer and suffix,
checksums and signatures and build).

Just some comments, more personal than formal, so none of them represents a
blocking issue:

1) I have to say that found very inconvenient that the source releases are
not distributed all together via the dist area.

2) Also related with the source distribution, but also a personal opinion,
I think such kind of releases with different versioning schemes make
developers' life much harder. For instance, this is what I needed for
building the releases from the source code repository:

  git clone https://git-wip-us.apache.org/repos/asf/incubator-nifi.git nifi
  cd nifi
  git checkout 37732bddcfcb2affcba1f3b4a9e3dd5ebd7b5a30
  cd nifi-parent/
  mvn clean install
  cd ..
  git checkout 1fc8453b36c1a1d600a911668f10249cf1e52ea7
  cd nifi-nar-maven-plugin/
  mvn clean install
  cd ..
  git checkout 65a07b6b634e04f44b5b89bfaf95e0ff35c3c68c
  cd nifi
  mvn clean install

which is not very convenient...



On Tue, May 12, 2015 at 4:50 PM, Matt Gilman <[email protected]>
wrote:

> +1 Release this package as nifi-0.1.0-incubating
>
> On Mon, May 11, 2015 at 4:37 PM, Mark Payne <[email protected]> wrote:
>
> > Hello
> >
> > I am pleased to be calling this vote for the source release of Apache
> NiFi
> > nifi-0.1.0-incubating.
> >
> > In this release, we factored out a parent maven artifact. This means that
> > we also had to do a new
> > release of the nifi-nar-maven-plugin, so there are a total of three
> > artifacts for this build:
> >
> > nifi-parent
> > nifi-nar-maven-plugin
> > nifi
> >
> > -----------------------
> > For nifi-parent:
> >
> > The source zip, including signatures, digests, etc. can be found at:
> > https://repository.apache.org/content/repositories/orgapachenifi-1049
> >
> >
> > The Git tag is nifi-parent-1.0.0-incubating-rc13
> > The Git commit ID is 37732bddcfcb2affcba1f3b4a9e3dd5ebd7b5a30
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=37732bddcfcb2affcba1f3b4a9e3dd5ebd7b5a30
> >
> >
> > Checksums of nifi-parent-1.0.0-incubating-source-release.zip:
> > MD5: fc22f90566b44dcc1e8637df2cfe71be
> > SHA1: 24ef57c27489e74be3bf5167d13b852be704d96d
> >
> > -----------------------
> > For nifi-nar-maven-plugin:
> >
> > The source zip, including signatures, digests, etc. can be found at:
> > https://repository.apache.org/content/repositories/orgapachenifi-1050
> >
> >
> > The Git tag is nifi-nar-maven-plugin-1.0.1-incubating-rc13
> > The Git commit ID is 1fc8453b36c1a1d600a911668f10249cf1e52ea7
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=1fc8453b36c1a1d600a911668f10249cf1e52ea7
> >
> >
> > Checksums of nifi-nar-maven-plugin-1.0.1-incubating-source-release.zip:
> > MD5: 90c6e9e8f7037df4aa41e6978e6f34ad
> > SHA1: 155b9e633a724e76fa9f223fafa8d9f92377fed9
> >
> > -----------------------
> > For nifi:
> >
> > The source zip, including signatures, digests, etc. can be found at:
> > https://repository.apache.org/content/repositories/orgapachenifi-1051
> >
> >
> > The Git tag is nifi-0.1.0-incubating-rc13
> > The Git commit ID is 65a07b6b634e04f44b5b89bfaf95e0ff35c3c68c
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;a=commit;h=65a07b6b634e04f44b5b89bfaf95e0ff35c3c68c
> >
> >
> > Checksums of nifi-0.1.0-incubating-source-release.zip:
> > MD5: 805d96637327885f38420ba6b9f39066
> > SHA1: dde266518632af33b432dd03d6da931aa27dbabc
> >
> > -----------------------
> > For all artifacts:
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/markap14.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/incubator/nifi/KEYS
> >
> >
> > Should the source release be successful we intend to make convenience
> > binaries available.  The
> > convenience binary of this source release along with the appropriate
> > hashes and signature can be found
> > here: https://dist.apache.org/repos/dist/dev/incubator/nifi
> >
> >
> > 121 issues were closed/resolved for this release:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12329276
> >
> >
> > The vote will be open for 72 hours.
> > Please download the release candidate and evaluate the necessary items
> > including checking hashes, signatures, build from source, and test.  The
> > please vote:
> >
> >
> > [ ] +1 Release this package as nifi-0.1.0-incubating
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because...
> >
>



-- 
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: [email protected]
w: http://redlink.co

Reply via email to