+1
- Files checked
- maven checked
- project created and tests executed
Some remarks:
- pom.ml scm tag is incorrect (set as HEAD but should be same as tag
name, see bin/MAVEN-RELEASE.md, "Make Apache Release")
- I guess better to configure tests execution on maven verify phase
Regards,
Sergey
+1 from me:
Checked:
- LICENSE
- NOTICE
- DISCLAIMER
- Apache RAT
- mvn clean package
- mvn clean verify
BTW: link to Git tag should be:
https://gitbox.apache.org/repos/asf?p=incubator-nlpcraft-java-client.git;a=tag;h=refs/tags/v0.5.0
Thanks,
--
Nikita Ivanov
Sergey
17.05.2020 04:10, Aaron Radzinski пишет:
NLPCraft-ers,
This is the vote for release of NLPCraft Java Client v0.5.0. Note that this
is the first ASF release of Java Client sub-project within Apache NLPCraft.
Quick links:
1. Apache dist location
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/java-client/>
1. Link for ZIP tarball
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/java-client/apache-nlpcraft-java-client-incubating-0.5.0.zip>
(SHA256
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/java-client/apache-nlpcraft-java-client-incubating-0.5.0.zip.sha256>,
PGP
<https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/java-client/apache-nlpcraft-java-client-incubating-0.5.0.zip.asc>
)
2. GitHub v0.5.0 tag
<https://issues.apache.org/jira/projects/NLPCRAFT/versions/12347774>
The vote is formal, see voting guidelines here:
https://www.apache.org/foundation/voting.html
+1 - to accept Apache NLPCraft - Java Client 0.5.0
0 - don't care either way
-1 - DO NOT accept Apache NLPCraft 0.5.0 - Java Client (explain why)
See notes on how to verify release here:
https://www.apache.org/info/verification.html
The vote will be held for 72 hours and will end on May 19, 2020 at midnight
MSK.
Thank you!