Paul, https://issues.apache.org/jira/browse/NLPCRAFT-179 filed to be addressed in the next release.
Thank you, -- Aaron Radzinski On Mon, Nov 23, 2020 at 12:29 AM Paul King <[email protected]> wrote: > +1 > > Checked hashes and signatures. > "mvn clean verify" passes > "mvn apache-rat:rat" passes > incubating in name > DISCLAIMER exists > NOTICE seems okay > LICENSE seems okay > no unexpected binary files > > Mentoring note about license header (same as last time): > * For files like NCBlowfishHasher.java, (correctly mentioned in LICENSE and > NOTICE, thanks) if the statement "Code almost entirely based on work of > ..." is indeed true, then I believe it is usually clearer to leave the > original license header in the source file and perhaps amend with > "Subsequent changes Copyright by the NLPCraft team and made under the > ASLv2..." but what you have is possibly okay - just not as clear. IANAL, > but my understanding is that you have the obligation to make it clear that > the requirements the original author requested for use of that file in > source form etc. are still in play and aren't overwritten by slapping the > ASLv2 header at the front of the file. > > Cheers, Paul. > > On Sun, Nov 22, 2020 at 4:55 AM Aaron Radzinski <[email protected] > > > wrote: > > > Sergey, > > Released was patched - please re-download and try again (it was only a > test > > fix). > > > > Thank you, > > -- > > Aaron Radzinski > > > > > > > > On Fri, Nov 20, 2020 at 4:28 AM Sergey Kamov <[email protected]> > wrote: > > > > > -1 > > > > > > gen-project and gen-model prepare invalid yaml and json tempaltes. > > > > > > Should be fixed. > > > > > > I'll create ticket. > > > > > > > > > > > > 19.11.2020 20:23, Aaron Radzinski пишет: > > > > NLPCraft-ers, > > > > This is a call for a vote to release Apache NLPCraft (incubating) > > version > > > > 0.7.2. This release includes bug fixes, incremental improvements as > > well > > > as > > > > new management utility. > > > > > > > > Release information: > > > > 1. Release location: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.2/ > > > > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.2 > > > > 4. JIRA issues fixed in release: > > > > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349298 > > > > 5. KEYS file: > > > > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS > > > > > > > > The vote will be open for at least 72 hours or until a necessary > number > > > of > > > > votes are reached. > > > > > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > Thank you, > > > > Aaron (NLPCraft community). > > > > -- > > > > Aaron Radzinski > > > > > > > > > >
