[
https://issues.apache.org/jira/browse/NLPCRAFT-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584794#comment-17584794
]
Sergey Kamov commented on NLPCRAFT-500:
---------------------------------------
ready for review i NLPCRAFT-500
Note please that
- imports processing logic kept as before, but
- fragments processing logic changed.
Fragments with same ID override each other, expect of fragments defined on
methods level. They override global fragments just on this method scope.
Look please thoroughly at 3 new tests: NCIDLFragmentsSpec,
NCIDLFragmentsOverridingSpec, NCIDLFragmentsOverridingSpec2 - check logic of
overring.
Let's discuss of something is implemented unexpected way.
> IDL fragments processing error.
> -------------------------------
>
> Key: NLPCRAFT-500
> URL: https://issues.apache.org/jira/browse/NLPCRAFT-500
> Project: NLPCraft
> Issue Type: Task
> Components: Main API
> Reporter: Sergey Kamov
> Assignee: Sergey Kamov
> Priority: Major
> Fix For: 1.0.0
>
>
> Look at TimeModel example configuration
> @NCIntent("fragment=city term(city)~\{# == 'opennlp:location'}")
> @NCIntent("intent=intent2 term~\{# == 'x:time'} fragment(city)")
> @NCIntent("intent=intent1 term=\{# == 'x:time'}")
> class TimeModel extends NCModelAdapter
> `intent1` and `intent2` are based on first annotation which contains
> `fragment`.
> But annotations processed in unordered way, so sometimes TimeModel test
> failed.
> (These annotations should be processed twice or we can try to do some another
> solution etc)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
