[
https://issues.apache.org/jira/browse/NUTCH-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894051#action_12894051
]
Julien Nioche commented on NUTCH-859:
-------------------------------------
{quote}
1. Build.xml file
org/apache/nutch/scoring/webgraph/*/.java,org/apache/nutch/tools/compat/*/.java
is no longer existed
(target compile-core-test, compile-core)
{quote}
the webgraph has not been ported to NutchBase yet, however since there is no
code in these packages this line in build.xml has no effect and could be
removed.
{quote}
2. solrindex-mapping.xml is not added
{quote}
indeed. well spotted
{quote}
We shoud convert SolrIndexer.java to run solrindex command in local mode
{quote}
what do you mean by that? Embedding SOLR in the reducers in order to generate
an index locally? You can put that as a new feature for 2.0, what we are trying
to do here is to make sure we are not missing any of the improvements done in
the last 12+ months on the trunk.
{quote}
3. /java/org/apache/nutch/crawl/FetchScheduleFactory.java
No need to use Class<?>, just Class is enough
{quote}
ok - not really relevant here (see comment above)
{quote}
4. nutch-default.xml
query-(basic|site|url)|summary-basic is not used
{quote}
true. we'll also need to remove the params in nutch-default.xml which won't be
used anymore. This can be done after we move to trunk though.
{quote}
5. nutchbase use fetcher.threads.per.queue, why not use other feature like
fetcher.threads.per.host, fetcher.threads.per.host.by.ip
{quote}
things are handled differently in the code but the feature is the same. look at
the code for more details
{quote}
6.Some java source contain $Id, some java source not, it is not unique style
// $Id: PrefixURLFilter.java 823614 2009-10-09 17:02:32Z ab $
// $Id$
{quote}
ok, can be part of the code cleanup after the move to trunk
{quote}
We should define a standard format rules for source code, then using eclipse to
format the whole source code in the same style
{quote}
agreed - can you create a separate JIRA for this please?
Thanks for your comments!
> Diff trunk and NutchBase
> -------------------------
>
> Key: NUTCH-859
> URL: https://issues.apache.org/jira/browse/NUTCH-859
> Project: Nutch
> Issue Type: Task
> Affects Versions: nutchbase
> Reporter: Julien Nioche
> Priority: Blocker
> Fix For: nutchbase
>
>
> Before we turn NutchBase into trunk we need to make sure that all (more or
> less) recent changes in the trunk have been ported to NutchBase. I have done
> that recently but given that there is a very large number of changes I might
> have missed a few things here and there.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
