[ 
https://issues.apache.org/jira/browse/NUTCH-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597515#comment-13597515
 ] 

Lewis John McGibbney edited comment on NUTCH-1031 at 3/8/13 8:26 PM:
---------------------------------------------------------------------

Hi Tejas. Sorry for taking forever to get around to this. 

* I really like to documentation within the patch. Big +1 for this
* Test all pass flawlessly.
* I like the retention of the main() method in o.a.n.p.RobotRulesParser

I've tested this on several websites, including many directories within sites 
like bbc.co.uk (check out the robots.txt)
I am +1 for this Tejas. Good work on this one, its been a long time in coming 
to Nutch.
I am keen to hear from others.

I have one trivial grudge, there is a typo in the usage message for the main 
method in RobotRulesParser. It should be 

{code}
Usage: RobotRulesParser <robots-file> <url-file> <agent-names>
{code}

instead of 

{code}
Usage: RobotRulesParser <robots-file> <robots-file> <agent-names>
{code} 
                
      was (Author: lewismc):
    Hi Tejas. Sorry for taking forever to get around to this. 

* I really like to documentation within the patch. Big +1 for this
* Test all pass flawlessly.
* I like the retention of the main() method in o.a.n.p.RobotRulesParser

I've tested this on several websites, including many directories within sites 
like bbc.co.uk (check out the robots.txt)
I am +1 for this Tejas. Good work on this one, its been a long time in coming 
to Nutch.
I am keen to hear from others.
                  
> Delegate parsing of robots.txt to crawler-commons
> -------------------------------------------------
>
>                 Key: NUTCH-1031
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1031
>             Project: Nutch
>          Issue Type: Task
>            Reporter: Julien Nioche
>            Assignee: Tejas Patil
>            Priority: Minor
>              Labels: robots.txt
>             Fix For: 1.7
>
>         Attachments: CC.robots.multiple.agents.patch, 
> CC.robots.multiple.agents.v2.patch, NUTCH-1031-trunk.v2.patch, 
> NUTCH-1031-trunk.v3.patch, NUTCH-1031-trunk.v4.patch, NUTCH-1031.v1.patch
>
>
> We're about to release the first version of Crawler-Commons 
> [http://code.google.com/p/crawler-commons/] which contains a parser for 
> robots.txt files. This parser should also be better than the one we currently 
> have in Nutch. I will delegate this functionality to CC as soon as it is 
> available publicly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to