[ https://issues.apache.org/jira/browse/NUTCH-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652130#comment-13652130 ]
Lewis John McGibbney commented on NUTCH-1527: --------------------------------------------- [~amuseme.lu] this looks like a great addition to trunk. The class comments in ElasticIndexWriter can be removed e.g. {code} +/** + * Created with IntelliJ IDEA. + * User: lemo + * Date: 4/28/13 + * Time: 9:57 PM + * To change this template use File | Settings | File Templates. + */ {code} Also we could do with a lot more method level documentation. As with indexer-solr we lack tests here and any tests which could be supplied would be the cherry on the cake. In all, good effort. I will struggle to test this one as I do not have a use case for elastic search right now :( > Port nutch-elasticsearch-indexer to Nutch > ----------------------------------------- > > Key: NUTCH-1527 > URL: https://issues.apache.org/jira/browse/NUTCH-1527 > Project: Nutch > Issue Type: Bug > Components: indexer > Affects Versions: 1.6, 2.1 > Reporter: Lewis John McGibbney > Assignee: lufeng > Priority: Minor > Fix For: 2.3, 1.8 > > Attachments: NUTCH-1527.patch > > > The source repos for this can be found here [0]. > This issue should be inline with the work already done by Julien and others > over at NUTCH-1047. > [0] https://github.com/ctjmorgan/nutch-elasticsearch-indexer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira