[ 
https://issues.apache.org/jira/browse/NUTCH-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901363#comment-13901363
 ] 

Markus Jelsma commented on NUTCH-1726:
--------------------------------------

Hi lufeng!

I don't understand, i have a clean Apache Nutch headings plugin, the same test 
fails for my patch and your patch. 

{code}
Testcase: testIt took 1.489 sec
Testcase: testMultiValueMetatags took 0.185 sec
        FAILED
One value of metatag with multiple values is missing: Test header h2 with span
junit.framework.AssertionFailedError: One value of metatag with multiple values 
is missing: Test header h2 with span
        at 
org.apache.nutch.parse.headings.TestHeadingsParseFilter.testMultiValueMetatags(TestHeadingsParseFilter.java:97)

{code}

I added truncate because perhaps some users may want to ignore long headers 
instead of truncating them. If i get a header containing 2kb of text, i think i 
would like to skip it, not truncate.

Markus

> HeadingsFilter does not find nested nodes
> -----------------------------------------
>
>                 Key: NUTCH-1726
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1726
>             Project: Nutch
>          Issue Type: Bug
>    Affects Versions: 1.7
>            Reporter: Markus Jelsma
>            Assignee: Markus Jelsma
>            Priority: Minor
>             Fix For: 1.8
>
>         Attachments: NUTCH-1726-trunk-v2.patch, NUTCH-1726-trunk.patch, 
> NUTCH-1726-trunk.patch
>
>
> Filter won't find:
> {code}
> <h1><span>apache nutch</span></h1>
> {code}
> The getNodeValue() tries to read data from children but should traverse nodes 
> instead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to