[ 
https://issues.apache.org/jira/browse/NUTCH-1844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris A. Mattmann updated NUTCH-1844:
-------------------------------------
    Description: 
While working on NUTCH-1526 in Review Board https://reviews.apache.org/r/9119/ 
[~lewismc] tried to test out the ./bin/nutch dump tool on 
src/testresources/testcrawl and found that it failed due to an old 
o.a.h.io.UTF8 key type (instead of the o.a.h.io.Text) type. 

I looked into this - how were Nutch tests passing using this old code? I found 
that Andrzej a long time ago wrote a tool to update the index from the old UFT8 
key format to Text - I also found that *no where in the Nutch code* is the 
testcrawl referenced.

My suggestion: 

* we remove the testcrawl (it's not used)
* if we don't remove it, we at least run Andrzej's tool on it and then upgrade 
it to use o.a.h.io.Text keys. 

I'll take care of this.


  was:
While working on NUTCH-1526 in Review Board http://reviews.apache.org/r9119/ 
[~lewismc] tried to test out the ./bin/nutch dump tool on 
src/testresources/testcrawl and found that it failed due to an old 
o.a.h.io.UTF8 key type (instead of the o.a.h.io.Text) type. 

I looked into this - how were Nutch tests passing using this old code? I found 
that Andrzej a long time ago wrote a tool to update the index from the old UFT8 
key format to Text - I also found that *no where in the Nutch code* is the 
testcrawl referenced.

My suggestion: 

* we remove the testcrawl (it's not used)
* if we don't remove it, we at least run Andrzej's tool on it and then upgrade 
it to use o.a.h.io.Text keys. 

I'll take care of this.



> testresources/testcrawl not referenced anywhere in code.
> --------------------------------------------------------
>
>                 Key: NUTCH-1844
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1844
>             Project: Nutch
>          Issue Type: Bug
>          Components: test
>            Reporter: Chris A. Mattmann
>            Assignee: Chris A. Mattmann
>             Fix For: 1.10
>
>
> While working on NUTCH-1526 in Review Board 
> https://reviews.apache.org/r/9119/ [~lewismc] tried to test out the 
> ./bin/nutch dump tool on src/testresources/testcrawl and found that it failed 
> due to an old o.a.h.io.UTF8 key type (instead of the o.a.h.io.Text) type. 
> I looked into this - how were Nutch tests passing using this old code? I 
> found that Andrzej a long time ago wrote a tool to update the index from the 
> old UFT8 key format to Text - I also found that *no where in the Nutch code* 
> is the testcrawl referenced.
> My suggestion: 
> * we remove the testcrawl (it's not used)
> * if we don't remove it, we at least run Andrzej's tool on it and then 
> upgrade it to use o.a.h.io.Text keys. 
> I'll take care of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to