> On March 2, 2015, 6:53 p.m., Julien Nioche wrote: > > Any reason why you can't have this in a separate plugin as an extension of > > IndexWriter? See > > [https://issues.apache.org/jira/browse/NUTCH-1949?focusedCommentId=14336272&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14336272]
Yep, I think we should do this, as a next step. I'll file a ticket to get this integrated into an IndexingPlugin, but I think this is +1 and good to go now. - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31579/#review74783 ----------------------------------------------------------- On March 2, 2015, 5:58 p.m., Giuseppe Totaro wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31579/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 5:58 p.m.) > > > Review request for nutch, Lewis McGibbney and Chris Mattmann. > > > Bugs: NUTCH-1949 > https://issues.apache.org/jira/browse/NUTCH-1949 > > > Repository: nutch > > > Description > ------- > > Patch fo NUTCH-1949: first version of the CommonCrawlDataDumper tool that > maps Nutch data into Common Crawl format. > > > Diffs > ----- > > trunk/src/bin/nutch 1662875 > trunk/src/java/org/apache/nutch/tools/AbstractCommonCrawlFormat.java > PRE-CREATION > trunk/src/java/org/apache/nutch/tools/CommonCrawlDataDumper.java > PRE-CREATION > trunk/src/java/org/apache/nutch/tools/CommonCrawlFormat.java PRE-CREATION > trunk/src/java/org/apache/nutch/tools/CommonCrawlFormatFactory.java > PRE-CREATION > trunk/src/java/org/apache/nutch/tools/CommonCrawlFormatJackson.java > PRE-CREATION > trunk/src/java/org/apache/nutch/tools/CommonCrawlFormatJettinson.java > PRE-CREATION > trunk/src/java/org/apache/nutch/tools/CommonCrawlFormatSimple.java > PRE-CREATION > trunk/src/java/org/apache/nutch/tools/FileDumper.java 1662875 > > Diff: https://reviews.apache.org/r/31579/diff/ > > > Testing > ------- > > Tested locally against Nutch segments. > > > Thanks, > > Giuseppe Totaro > >
