[ https://issues.apache.org/jira/browse/NUTCH-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503866#comment-14503866 ]
Lewis John McGibbney commented on NUTCH-1934: --------------------------------------------- This patch really needs tested thoroughly. It's a major refactoring of a >1000 line Java file which we all know as trunk Fetcher. Although no existing functionality has changed... I believe I've now implemented some method calls as static so we need to make sure this is OK. -- *Lewis* > Refactor Fetcher in trunk > ------------------------- > > Key: NUTCH-1934 > URL: https://issues.apache.org/jira/browse/NUTCH-1934 > Project: Nutch > Issue Type: Improvement > Components: fetcher > Affects Versions: 1.10 > Reporter: Lewis John McGibbney > Assignee: Lewis John McGibbney > Labels: memex > Fix For: 1.11 > > Attachments: NUTCH-1934-trunkv2.patch, NUTCH-1934.patch > > > Put simply > [Fetcher|https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java] > is too big. > This is kinda strange as the size of this file is unique (I think) from every > other class within Nutch. The others are reasonably well modularized and > split into constituent classes which make sense. -- This message was sent by Atlassian JIRA (v6.3.4#6332)