[ 
https://issues.apache.org/jira/browse/NUTCH-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213605#comment-15213605
 ] 

ASF GitHub Bot commented on NUTCH-2191:
---------------------------------------

Github user karanjeets commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/100#discussion_r57533636
  
    --- Diff: src/plugin/lib-htmlunit/ivy.xml ---
    @@ -0,0 +1,52 @@
    +<?xml version="1.0" ?>
    +
    +<!--
    +   Licensed to the Apache Software Foundation (ASF) under one or more
    +   contributor license agreements.  See the NOTICE file distributed with
    +   this work for additional information regarding copyright ownership.
    +   The ASF licenses this file to You under the Apache License, Version 2.0
    +   (the "License"); you may not use this file except in compliance with
    +   the License.  You may obtain a copy of the License at
    +
    +       http://www.apache.org/licenses/LICENSE-2.0
    +
    +   Unless required by applicable law or agreed to in writing, software
    +   distributed under the License is distributed on an "AS IS" BASIS,
    +   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +   See the License for the specific language governing permissions and
    +   limitations under the License.
    +-->
    +
    +<ivy-module version="1.0">
    +  <info organisation="org.apache.nutch" module="${ant.project.name}">
    +    <license name="Apache 2.0"/>
    +    <ivyauthor name="Apache Nutch Team" url="http://nutch.apache.org"/>
    +    <description>
    +        Apache Nutch
    +    </description>
    +  </info>
    +
    +  <configurations>
    +    <include file="../../../ivy/ivy-configurations.xml"/>
    +  </configurations>
    +
    +  <publications>
    +    <!--get the artifact from our module name-->
    +    <artifact conf="master"/>
    +  </publications>
    +
    +  <dependencies>
    +    <!-- begin selenium dependencies -->
    +    <dependency org="org.seleniumhq.selenium" name="selenium-java" 
rev="2.44.0" />
    --- End diff --
    
    @chrismattmann Thanks.
    
    @lewismc - So, for now, I will keep it the same way as it is and later when 
we downgrade selenium across the board, we will reference selenium in 
lib-htmlunit from lib-selenium plugin? Can you please confirm if that's the 
plan?


> Add protocol-htmlunit
> ---------------------
>
>                 Key: NUTCH-2191
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2191
>             Project: Nutch
>          Issue Type: New Feature
>          Components: protocol
>    Affects Versions: 1.11
>            Reporter: Markus Jelsma
>            Assignee: Chris A. Mattmann
>             Fix For: 1.12
>
>         Attachments: NUTCH-2191.patch, NUTCH-2191.patch, NUTCH-2191.patch, 
> NUTCH-2191.patch
>
>
> HtmlUnit is, opposed to other Javascript enabled headless browsers, a 
> portable library and should therefore be better suited for very large scale 
> crawls. This issue is an attempt to implement protocol-htmlunit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to