[
https://issues.apache.org/jira/browse/NUTCH-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241419#comment-16241419
]
ASF GitHub Bot commented on NUTCH-2442:
---------------------------------------
kpm1985 commented on issue #239: NUTCH-2442 Injector to stop if job fails to
avoid loss of CrawlDb
URL: https://github.com/apache/nutch/pull/239#issuecomment-342363973
This is somewhat of a tangent, but if we mavenize the build, we could use
some nice plugins for maven. Saw a few emails this week on this topic.
I looked into using nailgun and some other sweet things to ensure
consistency on a per commit basis, ie the maven import ordering plugin ( in
use under ASFLv2 in Fluo) for Log4J2.
Obviously, having each developer care enough to learn to import the style
into eclipse is good, a standard imo, but in the future we can automate
these styles. This is fantastic for formatting older class files etc..
Also, been lagging have lots of work but am serious about fixing old PR
(fyi for Sebastian)
Afaik ant is preferred less to maven.
On Nov 6, 2017 1:40 PM, "Sebastian Nagel" <notificati...@github.com> wrote:
> Merged #239 <https://github.com/apache/nutch/pull/239>.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/nutch/pull/239#event-1328519590>, or mute the
> thread
>
<https://github.com/notifications/unsubscribe-auth/Acg-LKQz6EMKf7kPeJawhe-nhiIecGFKks5sz3zigaJpZM4QSFzL>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Injector to stop if job fails to avoid loss of CrawlDb
> ------------------------------------------------------
>
> Key: NUTCH-2442
> URL: https://issues.apache.org/jira/browse/NUTCH-2442
> Project: Nutch
> Issue Type: Bug
> Components: injector
> Affects Versions: 1.13
> Reporter: Sebastian Nagel
> Priority: Critical
> Fix For: 1.14
>
>
> Injector does not check whether the MapReduce job is successful. Even if the
> job fails
> - installs the CrawlDb
> -- move current/ to old/
> -- replace current/ with an empty or potentially incomplete version
> - exits with code 0 so that scripts running the crawl workflow cannot detect
> the failure -- if Injector is run a second time the CrawlDb is lost (both
> current/ and old/ are empty or corrupted)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
