[ 
https://issues.apache.org/jira/browse/NUTCH-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292231#comment-16292231
 ] 

ASF GitHub Bot commented on NUTCH-2415:
---------------------------------------

sebastian-nagel commented on a change in pull request #219: NUTCH-2415 : Create 
a JEXL based IndexingFilter
URL: https://github.com/apache/nutch/pull/219#discussion_r157154504
 
 

 ##########
 File path: build.xml
 ##########
 @@ -1042,6 +1042,8 @@
         <source path="${plugins.dir}/index-geoip/src/java/" />
         <source path="${plugins.dir}/index-links/src/java/" />
         <source path="${plugins.dir}/index-links/src/test/" />
+        <source path="${plugins.dir}/index-jexl-filter/src/java/" />
 
 Review comment:
   - the index-jexl-filter dir should also be added to the Eclipse target: 
there will be 4 entries in the main build.xml
   - the plugin folders in build.xml are sorted lexicographically: 
index-jexl-filter should come before index-links
   - please also add the package to plugins.index in default.properties. That's 
required to list the pluging on the [Javadoc overview 
page](https://builds.apache.org/job/nutch-trunk/javadoc/)
   - also a package-info.java would be great

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Create a JEXL based IndexingFilter
> ----------------------------------
>
>                 Key: NUTCH-2415
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2415
>             Project: Nutch
>          Issue Type: New Feature
>          Components: plugin
>    Affects Versions: 1.13
>            Reporter: Yossi Tamari
>            Assignee: Jorge Luis Betancourt Gonzalez
>            Priority: Minor
>
> Following on NUTCH-2414 and NUTCH-2412, the requirement was raised for a 
> IndexingFilter plugin which will decide whether to index a document based on 
> a JEXL expression.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to