[
https://issues.apache.org/jira/browse/NUTCH-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519449#comment-16519449
]
ASF GitHub Bot commented on NUTCH-2600:
---------------------------------------
sebastian-nagel commented on issue #351: fix for NUTCH-2600: indexer-solr
refactoring
URL: https://github.com/apache/nutch/pull/351#issuecomment-399131220
Lgtm! Successfully tested with Solr 6.6.0. Thanks, @r0ann3l!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactoring indexer-solr
> ------------------------
>
> Key: NUTCH-2600
> URL: https://issues.apache.org/jira/browse/NUTCH-2600
> Project: Nutch
> Issue Type: Improvement
> Components: indexer, plugin
> Affects Versions: 1.14
> Reporter: Roannel Fernández Hernández
> Priority: Minor
> Fix For: 1.15
>
>
> indexer-solr includes an interface to define the parameters used by the
> plugin, however, in some cases this interface is not used and a string is
> used instead. Also, in index-writers.xml file, the commit.index parameter is
> never used in the code and the collection parameter is not included in
> index-writers.xml file.
> On the other hand, according to the configuration of indexer-solr plugin, it
> seems to support Basic Authentication but the username and password are never
> used. I don't know the reason for this, but I believe that it could be a good
> feature for Nutch and besides I think we should update Solrj library.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
