lewismc commented on code in PR #814:
URL: https://github.com/apache/nutch/pull/814#discussion_r1579883313
##########
src/java/org/apache/nutch/crawl/Generator.java:
##########
@@ -253,10 +256,7 @@ public void map(Text key, CrawlDatum value, Context
context)
try {
sort = scfilters.generatorSortValue(key, crawlDatum, sort);
} catch (ScoringFilterException sfe) {
- if (LOG.isWarnEnabled()) {
- LOG.warn(
- "Couldn't filter generatorSortValue for " + key + ": " + sfe);
- }
+ LOG.warn("Couldn't filter generatorSortValue for " + key + ": " + sfe);
Review Comment:
Please use parameterized logging.
```
LOG.warn("Couldn't filter generatorSortValue for {}: {}”, key, sfe);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@nutch.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
