[
https://issues.apache.org/jira/browse/NUTCH-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050478#comment-18050478
]
ASF GitHub Bot commented on NUTCH-3144:
---------------------------------------
sebastian-nagel opened a new pull request, #881:
URL: https://github.com/apache/nutch/pull/881
- adapt unit tests to changes introduced in
https://github.com/crawler-commons/crawler-commons/pull/478
- test for example given in Javadoc of
[getDomainSuffix](https://nutch.apache.org/documentation/javadoc/api/org/apache/nutch/util/URLUtil.html#getDomainSuffix(java.net.URL))
> URLUtil unit tests fail after upgrade to crawler-commons 1.6
> ------------------------------------------------------------
>
> Key: NUTCH-3144
> URL: https://issues.apache.org/jira/browse/NUTCH-3144
> Project: Nutch
> Issue Type: Bug
> Components: test
> Affects Versions: 1.22
> Reporter: Sebastian Nagel
> Assignee: Sebastian Nagel
> Priority: Major
> Fix For: 1.22
>
>
> {noformat}
> $> ant test-core -Dtestcase=TestURLUtil
> ...
> [junitlauncher] Running org.apache.nutch.util.TestURLUtil
> [junitlauncher] Tests run: 9, Failures: 2, Aborted: 0, Skipped: 0, Time
> elapsed: 0.535 sec
> BUILD FAILED
> $> grep -A1 FAILED build/test/TEST-org.apache.nutch.util.TestURLUtil.txt
> Test: testGetDomainSuffix() took 405 milli sec(s) FAILED: expected:
> <xn--fl-zia.no> but was: <flå.no>
> org.opentest4j.AssertionFailedError: expected: <xn--fl-zia.no> but was:
> <flå.no>
> --
> Test: testGetTopLevelDomain() took 1 milli sec(s) FAILED: expected:
> <xn--cg4bki> but was: <삼성>
> org.opentest4j.AssertionFailedError: expected: <xn--cg4bki> but was: <삼성>
> {noformat}
> The URLUtil class needs to be adapted to the changes introduced in
> [crawler-commons#478|https://github.com/crawler-commons/crawler-commons/pull/478].
> The issue was not discovered by GitHub workflows because of NUTCH-3143.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
