[
https://issues.apache.org/jira/browse/NUTCH-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18051146#comment-18051146
]
ASF GitHub Bot commented on NUTCH-3143:
---------------------------------------
lewismc opened a new pull request, #884:
URL: https://github.com/apache/nutch/pull/884
This is a PR for
[NUTCH-3143](https://issues.apache.org/jira/browse/NUTCH-3143).
## Root Causes Identified
1. **Artifact overwrite race condition** — Both `ubuntu-latest` and
`macos-latest` matrix jobs uploaded test results to the same artifact name
(`junit-test-results`) with `overwrite: true`. Whichever job finished last
would overwrite the other's results, causing inconsistent test counts between
runs.
2. **Gap in conditional test execution logic** — When a commit didn't match
any path filter (e.g., documentation-only changes), no test step was executed,
resulting in empty or missing test results.
3. **Insufficient job timeout** — The 30-minute timeout could potentially
cut off long-running test suites.
## Fixes Applied
- Changed artifact names to be OS-specific:
`junit-test-results-ubuntu-latest` and `junit-test-results-macos-latest`
- Added fallback test step to run all tests when no path filters match
- Increased job timeout from 30 to 45 minutes
- Updated junit-report workflow to download and merge results from both OS
artifacts
- Fixed invalid `include_skipped` input and added
`skip_comment_without_tests` to handle missing PR context gracefully
> GitHub workflow does not run all unit tests
> -------------------------------------------
>
> Key: NUTCH-3143
> URL: https://issues.apache.org/jira/browse/NUTCH-3143
> Project: Nutch
> Issue Type: Bug
> Components: build
> Affects Versions: 1.22
> Reporter: Sebastian Nagel
> Assignee: Lewis John McGibbney
> Priority: Critical
> Fix For: 1.22
>
>
> The GitHub workflow does not run all unit tests. The number of core unit
> tests differs from run to run:
> - in
> [1|https://github.com/apache/nutch/actions/runs/20325050290/job/58388368667#step:6:6330]:
> {noformat}
> [junitlauncher] Running org.apache.nutch.util.TestGZIPUtils
> [junitlauncher] Tests run: 3, Failures: 0, Aborted: 0, Skipped: 0, Time
> elapsed: 0.15 sec
> [junitlauncher] Running org.apache.nutch.util.TestMimeUtil
> BUILD SUCCESSFUL
> Total time: 11 minutes 6 seconds
> {noformat}
> - in
> [2|https://github.com/apache/nutch/actions/runs/20531278839/job/59020422063?pr=878#step:6:6504]:
> {noformat}
> [junitlauncher] Running org.apache.nutch.util.TestPrefixStringMatcher
> [junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
> elapsed: 0.053 sec
> [junitlauncher] Running org.apache.nutch.util.TestStringUtil
> BUILD SUCCESSFUL
> Total time: 13 minutes 4 seconds
> {noformat}
> - in
> [3|https://github.com/apache/nutch/actions/runs/20531278839/job/59020422044?pr=878#step:6:6492]:
> {noformat}
> [junitlauncher] Running org.apache.nutch.service.TestNutchServer
> [junitlauncher] Tests run: 1, Failures: 0, Aborted: 0, Skipped: 0, Time
> elapsed: 0.329 sec
> [junitlauncher] Running org.apache.nutch.tools.TestCommonCrawlDataDumper
> BUILD SUCCESSFUL
> Total time: 13 minutes 19 seconds
> {noformat}
> Not running all tests might cause that issues are not discovered.
> Note: this may be obsoleted by NUTCH-2934.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
