[ 
https://issues.apache.org/jira/browse/NUTCH-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18063887#comment-18063887
 ] 

ASF GitHub Bot commented on NUTCH-1446:
---------------------------------------

sebastian-nagel commented on code in PR #905:
URL: https://github.com/apache/nutch/pull/905#discussion_r2901705464


##########
src/java/org/apache/nutch/indexer/IndexerOutputFormat.java:
##########
@@ -40,32 +33,67 @@ public RecordWriter<Text, NutchIndexAction> getRecordWriter(
     Configuration conf = context.getConfiguration();
     final IndexWriters writers = IndexWriters.get(conf);
 
-    String name = getUniqueFile(context, "part", "");
-    writers.open(conf, name);
+    // open writers (no temporary file output anymore)
+    writers.open(conf, "index");

Review Comment:
   The method [open(Configuration conf, String 
name)](https://nutch.apache.org/documentation/javadoc/api/org/apache/nutch/indexer/IndexWriter.html#open(org.apache.hadoop.conf.Configuration,java.lang.String))
 of the IndexWriter class is deprecated. Once it is finally removed, the 
`indexName` parameter is not used anymore. So, this is no real problem.





> Port NUTCH-1444 to trunk (Indexing should not create temporary files)
> ---------------------------------------------------------------------
>
>                 Key: NUTCH-1446
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1446
>             Project: Nutch
>          Issue Type: Bug
>            Reporter: Ferdy
>            Priority: Major
>             Fix For: 1.23
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to