[
https://issues.apache.org/jira/browse/NUTCH-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098203#comment-18098203
]
ASF GitHub Bot commented on NUTCH-3191:
---------------------------------------
lewismc commented on PR #943:
URL: https://github.com/apache/nutch/pull/943#issuecomment-5046722633
Quick heads up, I created a new SonarCloud Quality Gate profile for us named
"Nutch Way" which implements all of Sonar's best practices with the exception
that coverage on new code is reduced from 80% to 0%. Reason being, imho 80% was
simply too high. We never had project policy so 80% was superfluous anyway.
> Fix SonarCloud PR analysis: missing JaCoCo XML, test binaries path, and
> source encoding warnings
> ------------------------------------------------------------------------------------------------
>
> Key: NUTCH-3191
> URL: https://issues.apache.org/jira/browse/NUTCH-3191
> Project: Nutch
> Issue Type: Bug
> Components: ci/cd
> Affects Versions: 1.22
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.23
>
>
> SonarCloud pull request analysis currently reports three issues:
> * File encoding problems in source code (scanner logs)
> * Invalid {{sonar.java.test.binaries}} — no match for {{build/*/test}}
> * {{{}{}}}No coverage report at
> {{sonar.coverage.jacoco.xmlReportPaths=build/coverage/jacoco.xml}}
> *Root causes*
> * The CI build generates JaCoCo XML via {{ant jacoco-report}} but uploads
> only {{{}build/coverage/*.exec{}}}, so Sonar never sees {{{}jacoco.xml{}}}.
> * Plugin test classes live under {{{}build/<plugin>/test/{}}}, but build
> artifacts only upload {{{}**/classes/**/*.class{}}}, so {{build/*/test}} is
> empty at scan time.
> * {{sonar.sources}} includes all of {{{}src/plugin{}}}, so binary/BOM
> fixtures under {{sample/}} and {{data/}} are indexed as source.
> I'm not sure if this was the result of the recent work to the SonarCloud CI
> workflow, regardless, I'll get a patch cooked up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
