lewismc opened a new pull request, #958: URL: https://github.com/apache/nutch/pull/958
PR for [NUTCH-3197](https://issues.apache.org/jira/browse/NUTCH-3197) Follow-up to [NUTCH-3196](https://github.com/apache/nutch/pull/947) (Child A: Yetus false-positive baselines). This is **Child B** of the Yetus master precommit initiative: fix real defects the gate correctly reported, without taking on historical style debt (Child C) or shellcheck warnings/notes (Child D). **Fork:** `lewismc/nutch` → `apache/nutch` (replaces incorrectly opened #956 from upstream branch). ## Summary - Fix 11 shellcheck **errors** in `src/bin/crawl` and `src/bin/nutch` (SC2071, SC2144, SC2242, SC2145) with behavior-preserving edits - Fix SC2006 on cygpath line introduced by the SC2144 refactor (`$(...)` instead of backticks) - Add `@audience` / `@stability` shelldocs annotations to five helper functions in `src/bin/crawl` - Restructure `docker/Dockerfile` for hadolint (combined RUNs, quoting); waive DL3018 via `.hadolint.yaml` - Exclude `src/plugin/parse-js/sample/` from jshint via `.yetus/excludes.txt` (test fixture, not production JS) Product **codespell** typos are in a linked follow-up PR from the same fork. ## Out of scope (sibling issues) - Historical blanks/tabs, `@author`, markdownlint → Child C (NUTCH-3198) - Shellcheck warnings/notes in bin scripts → Child D (NUTCH-3199) - Product codespell typos → linked PR from `NUTCH-3197-codespell` ## Test plan - [x] `ant clean runtime test` - [x] `shellcheck -S error src/bin/crawl src/bin/nutch` — no errors - [ ] Yetus CI clears shellcheck, shelldocs, hadolint, jshint on changed lines Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
