[ 
https://issues.apache.org/jira/browse/NUTCH-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18118194#comment-18118194
 ] 

ASF GitHub Bot commented on NUTCH-3214:
---------------------------------------

github-actions[bot] commented on PR #970:
URL: https://github.com/apache/nutch/pull/970#issuecomment-5787778212

   ## Apache Yetus test-patch report
   
   |            |
   |------------|
   | -1 overall |
   
   |      |            |         |                                              
   |                                                                            
                                    |
   
|------|------------|---------|-------------------------------------------------|----------------------------------------------------------------------------------------------------------------|
   | Vote | Subsystem  | Runtime | Log                                          
   | Comment                                                                    
                                    |
   |      |            |         |                                              
   | Prechecks                                                                  
                                    |
   | +1   | dupname    | 0m 1s   |                                              
   | No case conflicting files found.                                           
                                    |
   | -1   | @author    | 0m 0s   | 
[/results-author.txt](/results-author.txt)\</\> | The patch appears to contain 
1 @author tags which the community has agreed to not allow in code 
contributions. |
   |      |            |         |                                              
   | master Compile Tests                                                       
                                    |
   | +1   | javadoc    | 0m 1s   |                                              
   | master passed                                                              
                                    |
   |      |            |         |                                              
   | Patch Compile Tests                                                        
                                    |
   | +1   | codespell  | 0m 2s   |                                              
   | No new issues.                                                             
                                    |
   | +1   | detsecrets | 0m 34s  |                                              
   | No new issues.                                                             
                                    |
   | +1   | blanks     | 0m 0s   |                                              
   | The patch has no blanks issues.                                            
                                    |
   | +1   | javadoc    | 0m 1s   |                                              
   | the patch passed                                                           
                                    |
   |      |            |         |                                              
   | Other Tests                                                                
                                    |
   | +1   | asflicense | 0m 1s   |                                              
   | The patch does not generate ASF License warnings.                          
                                    |
   |      |            | 0m 46s  |                                              
   |                                                                            
                                    |
   
   |                |                                                           
                                                       |
   
|----------------|------------------------------------------------------------------------------------------------------------------|
   | Subsystem      | Report/Notes                                              
                                                       |
   | GITHUB PR      | https://github.com/apache/nutch/pull/970                  
                                                       |
   | Optional Tests | dupname asflicense codespell detsecrets javac javadoc     
                                                       |
   | uname          | Linux 2d88d53ead3b 6.17.0-1022-azure \#22-Ubuntu SMP Mon 
Jul 27 17:24:03 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool     | nobuild                                                   
                                                       |
   | Personality    | /github/workspace/.yetus/personality.sh                   
                                                       |
   | git revision   | master / 0803bdb01afbf7bc340f3b6546df731cd9d96974         
                                                       |
   | Default Java   | Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04                
                                                       |
   | modules        | C: . U: .                                                 
                                                       |
   | versions       | git=2.34.1 codespell=2.4.1 detsecrets=1.5.0               
                                                       |
   | Powered by     | Apache Yetus 0.15.1 https://yetus.apache.org              
                                                       |
   
   This message was automatically generated.
   
   <!

> Remove Javadoc @author tags so Apache Yetus author check passes
> ---------------------------------------------------------------
>
>                 Key: NUTCH-3214
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3214
>             Project: Nutch
>          Issue Type: Improvement
>          Components: ci/cd
>    Affects Versions: 1.23
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>            Priority: Trivial
>             Fix For: 1.24
>
>
> Apache Yetus test-patch is voting -1 on the @author plugin because Nutch 
> still has Javadoc @author tags in Java sources.
> The GitHub workflow (.github/workflows/yetus.yml) runs 
> apache/[email protected] with plugins: all (minus jira, gitlab, 
> unit, compile). The author plugin fails when it finds @author in the patch 
> or, on master, in the tree. Typical vote text:
>   _*-1 @author  The patch appears to contain N @author tags which the 
> community has agreed to not allow in code contributions.*_
> This matches long-standing ASF practice: author tags are discouraged because 
> they confuse ownership (ASF copyright, not per-file authors) and committer 
> protection. Authorship belongs in git history and release notes, not in 
> source files. Same cleanup as Hadoop (HADOOP-1147 / HADOOP-6031) and other 
> ASF projects.
> Proposed change
> - Strip @author (and only those) Javadoc lines from Nutch-owned Java sources.
> - Do not rewrite surrounding comments beyond dropping the tags.
> - Do not add Yetus author-ignore-list entries for these files; the tags 
> should go away rather than be excepted.
> - No runtime or API change.
> Authors remain visible via git log / git blame. Do not add names to 
> CHANGES.md as part of this cleanup.
> Acceptance
> - No @author tags remain in Nutch Java sources.
> - Apache Yetus author check votes +1 on a follow-up PR and on master.
> This is mechanical Javadoc cleanup so Yetus CI can go green; it is not a 
> functional bug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to