Lewis John McGibbney created NUTCH-3217:
-------------------------------------------
Summary: Clear ShellCheck findings in src/bin/crawl and
src/bin/nutch
Key: NUTCH-3217
URL: https://issues.apache.org/jira/browse/NUTCH-3217
Project: Nutch
Issue Type: Improvement
Components: bin
Affects Versions: 1.23
Reporter: Lewis John McGibbney
Assignee: Lewis John McGibbney
Fix For: 1.24
Master Yetus run 36915201085 reports 64 ShellCheck issues (shellcheck 0.10.0):
48 in {{src/bin/crawl}} and 16 in {{{}src/bin/nutch{}}}. Rules:
* SC2086 unquoted expansions (21)
* SC2006 legacy backticks (20)
* SC2206 word-splitting on arrays (7)
* SC2046 unquoted command substitution (5)
* SC2003 {{expr}} (3)
* SC2164 {{cd}} without failure handling (2)
* SC2236 {{! -z}} (2)
* SC2021, SC2012, SC2196, SC2166 (1 each)
Update the scripts to satisfy ShellCheck while keeping the crawl and nutch
command-line behavior. Prefer quoting, {{{}$(...){}}}, and arithmetic expansion
over disabling rules.
This is the warning/note follow-up already tracked as NUTCH-3199 (child D of
NUTCH-3195). No functional change intended.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
