[
https://issues.apache.org/jira/browse/NUTCH-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18125860#comment-18125860
]
ASF GitHub Bot commented on NUTCH-3215:
---------------------------------------
sebastian-nagel commented on code in PR #974:
URL: https://github.com/apache/nutch/pull/974#discussion_r4238209138
##########
src/java/org/apache/nutch/publisher/NutchPublishers.java:
##########
@@ -32,7 +32,7 @@ public class NutchPublishers extends Configured implements
NutchPublisher{
private Configuration conf;
public NutchPublishers(Configuration conf) {
- this.conf = conf;
+ this.conf = conf;
Review Comment:
Same as above: indentation lost.
##########
src/java/org/apache/nutch/crawl/CrawlDb.java:
##########
@@ -342,12 +342,12 @@ else if(args.containsKey(Nutch.ARG_SEGMENTS)) {
Object segments = args.get(Nutch.ARG_SEGMENTS);
ArrayList<String> segmentList = new ArrayList<>();
if(segments instanceof ArrayList) {
- segmentList = (ArrayList<String>)segments;
+ segmentList = (ArrayList<String>)segments;
Review Comment:
Looks like here the code formatting should be applied. The indentation is
now lost.
But also the preceding line `if(segments ...` does follow the code
formatting rules.
##########
src/java/org/apache/nutch/util/ProtocolStatusStatistics.java:
##########
@@ -50,10 +50,10 @@
* An example output run showing the number of encountered status
* codes such as 200, 300, and a count of un-fetched record.
*
- * 38 200
Review Comment:
Should be inside `<pre>`
> Remove trailing whitespace reported by Yetus blanks on master
> -------------------------------------------------------------
>
> Key: NUTCH-3215
> URL: https://issues.apache.org/jira/browse/NUTCH-3215
> Project: Nutch
> Issue Type: Improvement
> Components: ci/cd
> Affects Versions: 1.23
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Minor
> Fix For: 1.24
>
>
> Apache Yetus test-patch on the master branch reports:
> The source tree has 1740 line(s) that end in blanks.
> This is the Yetus "blanks" plugin (EOL trailing spaces) on a full-tree run,
> not a patch-only check. See .github/workflows/yetus.yml and
> https://yetus.apache.org/documentation/0.15.1/precommit/plugins/blanks/
> A local scan of git-tracked UTF-8 files shows on the order of ~1.8k lines
> with trailing spaces. After excluding CHANGES.md (already listed in
> .yetus/blanks-eol.txt), the remainder is ~1740 and is concentrated in src/
> (Java, plugin XML, HTML test samples) plus smaller counts in conf/, ivy/,
> default.properties, and bundled license text.
> Why this should be fixed:
> * Master Yetus stays red/noisy for a mechanical style issue.
> * New PRs inherit the full-tree baseline, which drowns real patch findings.
> * Trailing spaces are not part of Nutch's intended formatting
> (eclipse-codeformat.xml).
> No functional change is intended.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
