[
https://issues.apache.org/jira/browse/NUTCH-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18128070#comment-18128070
]
ASF GitHub Bot commented on NUTCH-3199:
---------------------------------------
lewismc opened a new pull request, #980:
URL: https://github.com/apache/nutch/pull/980
PR for [NUTCH-3199](https://issues.apache.org/jira/browse/NUTCH-3199)
Needless to say, this needs thorough testing. As a result I'm going to
trigger a smoke test.
Local testing exercised th shellcheck tooling and a test crawl for several
rounds. More to come in testing.
I'd also like to evaluate https://github.com/TypedDevs/bashunit
> Yetus: harden bin/crawl and bin/nutch for remaining shellcheck findings
> -----------------------------------------------------------------------
>
> Key: NUTCH-3199
> URL: https://issues.apache.org/jira/browse/NUTCH-3199
> Project: Nutch
> Issue Type: Sub-task
> Components: ci/cd
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.24
>
>
> Even after errors are gone, shellcheck still reports on the order of
> sixtywarnings and notes in the two driver scripts—mostly quoting, legacy
> backticks, and related style that is easy to get wrong in a big bang rewrite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
