For opening a PR, usually you can just fork the repo and create a branch in
the forked repo, and then open a PR. It is not necessary to create a branch
in the original repo only for a PR.

You can open a branch for a big feature, which usually needs a lot of
commits and also a very long time before merge it back to master.

Thanks.

David Sidrane <david.sidr...@nscdg.com> 于2019年12月21日周六 下午9:18写道:

> Fine with me Greg has the patches (we all do - it is in the email)
>
> Xiang did you look a the PR? There is important content in it that done not
> get conveyed in a patch.
>
> -----Original Message-----
> From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com]
> Sent: Saturday, December 21, 2019 5:14 AM
> To: dev@nuttx.apache.org
> Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8
> GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]
>
> This is David's suggested workflow, but it still in the discussing or
> voting process?
> Before we get the approvement from community, we can't apply this
> process now  because its' unfailr to other upcomming potential
> suggestion.
> So my suggestion is still to keep the old process: Greg review and
> commit the patch to master of ASF until we approve the new workflow.
>
> On Sat, Dec 21, 2019 at 9:04 PM David Sidrane <david.sidr...@nscdg.com>
> wrote:
> >
> > Ok. But that feels wrong. Aren't we going to have more than one set of
> > eyes
> > on things? I do make a lot of mistakes.
> >
> > I will let it sit a day and give a PMC member a chance to review it.
> >
> > -----Original Message-----
> > From: Gregory Nutt [mailto:spudan...@gmail.com]
> > Sent: Saturday, December 21, 2019 4:56 AM
> > To: dev@nuttx.apache.org
> > Subject: Re: [incubator-nuttx] 05/05: imxrt106x:pinout add ALT 8
> > GPIO_GPT2_COMPARE3 & fix GPIO_GPT1_CAPTURE[1|2]
> >
> >
> > > Ut-oh It was not intended to be an abuse: This is how PR's or done all
> > > the
> > > GH projects I am on as a commiter.
> > > It is a branch in the repo so like you have always done with patches,
> > > you
> > > or
> > > any of the PMC)can make change to it if need be.
> > > It is PR to master in the same repo.
> > >
> > > The process is simple: review it (fix it if need be), merge it and
> > > delete
> > > the branch.
> > >
> > Then you should do that.  I won't
>

Reply via email to