Hold on!
Having a coding standard with 4000+ files in the repo that do not pass the
test…
…reminds me of this great line…
"This is the problem with issuing purity tests you cannot yourself pass"
Clear, Consistent, Standardized Coding Style
--------------------------------------------
o Strict conformance to the NuttX coding style. No "revolutionary"
changes to the coding standard (but perhaps some "evolutionary"
changes).
o Personal or organizational preference is not a justification for a
coding style change.
o Nothing can come into NuttX that does not follow the coding standard.
o Expediency is not a justification for violating the coding standard.
The NuttX coding standard can be found here:
http://www.nuttx.org/doku.php?id=documentation:codingstandard
How can you be suggesting facilitating this to continue this?
It is a violation of the INVIOLABLES.txt!.
"
For example, if people send a patch or pull request, nxstyle will
complain if the original file already has the style issue even the
contrbutor don't modify that portion.
"
Rule is: If you change a file you fix the coding standard in it.
The real issues is the code that is not compliant is used by other and
spreads like a weed!
Kill the weeds!
David
-----Original Message-----
From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com]
Sent: Monday, December 30, 2019 7:45 AM
To: dev@nuttx.apache.org
Subject: Re: Working Effectively (was Point of Order)
On Mon, Dec 30, 2019 at 11:05 PM David Sidrane <david.sidr...@nscdg.com>
wrote:
>
> >Haitao is preparing a script for style check, the feature include:
> >1.Auto build nxstyle
>
> 2.Improve nxstyle to check the partial file for supporting patch like file
>
> Are you saying only check the files changed?
>
Yes, I mean that nxstyle just check the changing line.
> If not would you please explain and give and an example of use case of
this?
>
For example, if people send a patch or pull request, nxstyle will
complain if the original file already has the style issue even the
contrbutor don't modify that portion.
> >3.Input can be the source files, patch file or commit id
>
> -----Original Message-----
> From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com]
> Sent: Monday, December 30, 2019 6:20 AM
> To: priv...@nuttx.apache.org
> Subject: Re: Working Effectively (was Point of Order)
>
> On Sun, Dec 15, 2019 at 3:26 AM Gregory Nutt <spudan...@gmail.com> wrote:
> >
> >
> > .... Perhaps we should get Jira up to track PPMC issues? Perhaps a
group
> > issues list on Jira could coordinate what needs to get done?
> >
> > This are the things that are in progress now and need to be monitored:
> >
> > Discussion and vote for new committers
> > Transfer of nuttx.org content to Confluence. Justin mentioned that the
> > ticket is in place to do this now.
>
> It's better to:
> 1.redirect nuttx.org to nuttx.incubator.apache.org
> 2.nuttx.incubator.apache.org host the content from
> https://github.com/apache/incubator-nuttx-website
> 3.user can navagte to wiki from the home page.
> Brennan, do you know how to update nuttx.incubator.apache.org? INFRA
> send me a link:
>
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories
>
> > Transfer the NuttX repositories. The SGA has been signed and submitted.
> > There is no INFRA ticket to do this yet.
> > Workflow planning and implementation. Not much progress here. We need
to
> > have a requirements document that we all concur with. Implementation
> > depends having those requirements and on having the GIT repositories in
> > place.
> >
>
> Haitao is preparing a script for style check, the feature include:
> 1.Auto build nxstyle
> 2.Improve nxstyle to check the partial file for supporting patch like file
> 3.Input can be the source files, patch file or commit id
>
> > Am I missing anything?
> >
> > We should set some objectives. Do you think we could get 3 of the
above 4
> > completed next week?
> >
> > Greg
> >
> >
