On Fri, Jan 3, 2020 at 3:10 AM Gregory Nutt <spudan...@gmail.com> wrote: > > Here is the summary of build test problems that I have seen. I may > still encounter more. > > Question: Who is going to do the PRs for all of these? I will merge > the PRs an retest them, but someone else needs to submit them. I have > suggested those committers most reponsible for the the bad commits: > > Configuration: imxrt1020-evk/:netnsh and MANY more. > Recommended Fixer: Xiao Xiang > Error: > > icmp/icmp_netpoll.c: In function 'icmp_poll_eventhandler': > icmp/icmp_netpoll.c:129:11: warning: implicit declaration of function > 'nxsem_post'; did you mean 'sem_post'? > [-Wimplicit-function-declaration] > nxsem_post(info->fds->sem); > ^~~~~~~~~~ > sem_post > > I am doing a build test now. Yes, I am seeing this new warning too (A > LOT). But I am also seeing 'ret may be used uninitialized in this > function" in the return value of icmp_pollsetup() in the same file, > icmp/icmp_netpoll.c >
fix by: https://github.com/apache/incubator-nuttx/pull/23 > Configuration: spresense:lte > Recommended Fixer: Xiao Xiang > Error: > > modem/altair/altmdm_sys.c: In function 'altmdm_sys_initlock': > modem/altair/altmdm_sys.c:79:9: warning: implicit declaration of > function 'nxsem_init'; did you mean 'sem_init'? > [-Wimplicit-function-declaration] > ret = nxsem_init(&handle->sem, 0, 1); > ^~~~~~~~~~ > sem_init > modem/altair/altmdm_sys.c: In function 'altmdm_sys_deletelock': > modem/altair/altmdm_sys.c:110:9: warning: implicit declaration of > function 'nxsem_destroy'; did you mean 'sem_destroy'? > [-Wimplicit-function-declaration] > ret = nxsem_destroy(&handle->sem); > ^~~~~~~~~~~~~ > sem_destroy > modem/altair/altmdm_sys.c: In function 'altmdm_sys_lock': > modem/altair/altmdm_sys.c:141:9: warning: implicit declaration of > function 'nxsem_wait_uninterruptible' [-Wimplicit-function-declaration] > ret = nxsem_wait_uninterruptible(&handle->sem); > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > modem/altair/altmdm_sys.c: In function 'altmdm_sys_unlock': > modem/altair/altmdm_sys.c:169:9: warning: implicit declaration of > function 'nxsem_post'; did you mean 'sem_post'? > [-Wimplicit-function-declaration] > ret = nxsem_post(&handle->sem); > ^~~~~~~~~~ > sem_post > modem/altair/altmdm_sys.c: In function 'altmdm_sys_getcsemvalue': > modem/altair/altmdm_sys.c:322:9: warning: implicit declaration of > function 'nxsem_getvalue'; did you mean 'sem_getvalue'? > [-Wimplicit-function-declaration] > ret = nxsem_getvalue(&handle->sem, value); > ^~~~~~~~~~~~~~ > sem_getvalue > modem/altair/altmdm_sys.c: In function 'altmdm_sys_waitflag': > modem/altair/altmdm_sys.c:480:23: warning: implicit declaration of > function 'nxsem_trywait'; did you mean 'sem_trywait'? > [-Wimplicit-function-declaration] > if (nxsem_trywait(&handle->sem) < 0) > ^~~~~~~~~~~~~ > sem_trywait > modem/altair/altmdm_sys.c:529:17: warning: implicit declaration of > function 'nxsem_timedwait_uninterruptible' [-Wimplicit-function-declaration] > ret = nxsem_timedwait_uninterruptible(&handle->sem, &abs_time); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > arm-none-eabi-ld: > /home/gnutt/projects/nuttx/master/nuttx/staging/libdrivers.a(altmdm_sys.o): > in function `altmdm_sys_lock': > /home/gnutt/projects/nuttx/master/nuttx/drivers/modem/altair/altmdm_sys.c:141: > undefined reference to `nxsem_wait_uninterruptible' > arm-none-eabi-ld: > /home/gnutt/projects/nuttx/master/nuttx/staging/libdrivers.a(altmdm_sys.o): > in function `altmdm_sys_waitcsem': > /home/gnutt/projects/nuttx/master/nuttx/drivers/modem/altair/altmdm_sys.c:262: > undefined reference to `nxsem_wait_uninterruptible' > arm-none-eabi-ld: > /home/gnutt/projects/nuttx/master/nuttx/staging/libdrivers.a(altmdm_sys.o): > in function `altmdm_sys_waitflag': > /home/gnutt/projects/nuttx/master/nuttx/drivers/modem/altair/altmdm_sys.c:529: > undefined reference to `nxsem_timedwait_uninterruptible' > arm-none-eabi-ld: > /home/gnutt/projects/nuttx/master/nuttx/drivers/modem/altair/altmdm_sys.c:540: > undefined reference to `nxsem_wait_uninterruptible' > fix by: https://github.com/apache/incubator-nuttx/pull/30 > Configuration: lpc4088-devkit:nsh > Recommended Fixer: Xiao Xiang > Error: > > make[3]: *** No rule to make target '.updated'. Stop. > make[2]: [registry/.updated] Error 2 (ignored) > make[3]: *** No rule to make target '.updated'. Stop. > make[2]: [registry/.updated] Error 2 (ignored) > > fix by: https://github.com/apache/incubator-nuttx-apps/pull/3 > Configuration: stm32f429i-disco:nxhello > Recommended Fixer: Alan Carvalho de Assis > Error: > > chip/stm32_fmc.c: In function 'stm32_fmc_sdram_set_timing': > chip/stm32_fmc.c:163:15: error: expected ';' before 'uint32_t' > uint32_t val > ^ > ; > uint32_t sdtr; > ~~~~~~~~ > chip/stm32_fmc.c:170:3: error: 'val' undeclared (first use in this function) > val = getreg32(sdtr); > ^~~ > chip/stm32_fmc.c:170:3: note: each undeclared identifier is reported > only once for each function it appears in > chip/stm32_fmc.c: In function 'stm32_fmc_sdram_set_control': > chip/stm32_fmc.c:186:15: error: expected ';' before 'uint32_t' > uint32_t val > ^ > ; > uint32_t sdcr; > ~~~~~~~~ > chip/stm32_fmc.c:193:3: error: 'val' undeclared (first use in this function) > val = getreg32(sdcr); > ^~~ > > Greg > >
