maht commented on a change in pull request #3: Initial checkin CI related 
scripts and testlist files
URL: 
https://github.com/apache/incubator-nuttx-testing/pull/3#discussion_r373740867
 
 

 ##########
 File path: cibuild.sh
 ##########
 @@ -0,0 +1,171 @@
+#!/usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+WD=$PWD
+nuttx=$WD/../nuttx
+apps=$WD/../apps
+tools=$WD/../tools
+prebuilt=$WD/../prebuilt
+
+# genromfs
+install=("if [ ! -d \"$prebuilt/genromfs/usr/bin\" ]; then \
+            if [ ! -d "$tools" ]; then \
+              git clone https://github.com/nuttx/tools.git $tools; \
+            fi; \
+            mkdir -p $prebuilt; cd $tools; \
+            tar zxf genromfs-0.5.2.tar.gz -C $prebuilt; \
+            cd $prebuilt/genromfs-0.5.2; \
+            make install PREFIX=$prebuilt/genromfs; \
+            cd $prebuilt; rm -rf genromfs-0.5.2; \
+          fi; \
+          genromfs -h; \
+          ")
+path=("$prebuilt/genromfs/usr/bin")
+
+# kconfig-frontends
+install+=("if [ ! -d \"$prebuilt/kconfig-frontends/bin\" ]; then \
+             cd $tools/kconfig-frontends; \
+             ./configure --prefix=$prebuilt/kconfig-frontends --enable-mconf 
--disable-gconf --disable-qconf --enable-static; \
+             make install; \
+             cd $tools; git clean -xfd; \
+           fi; \
+           ")
+path+=("$prebuilt/kconfig-frontends/bin")
+
+# arm gcc toolchain
+install+=("if [ ! -d \"$prebuilt/gcc-arm-none-eabi/bin\" ]; then \
+             cd $prebuilt; \
+             wget 
https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/RC2.1/gcc-arm-none-eabi-9-2019-q4-major-x86_64-linux.tar.bz2;
 \
+             tar jxf gcc-arm-none-eabi-9-2019-q4-major-x86_64-linux.tar.bz2; \
+             mv gcc-arm-none-eabi-9-2019-q4-major gcc-arm-none-eabi; \
+             rm gcc-arm-none-eabi-9-2019-q4-major-x86_64-linux.tar.bz2; \
+           fi; \
+           arm-none-eabi-gcc --version; \
+           ")
+path+=("$prebuilt/gcc-arm-none-eabi/bin")
+
+# mips gcc toolchain
+install+=("if [ ! -d \"$prebuilt/pinguino-compilers/linux64/p32/bin\" ]; then \
+             cd $prebuilt; \
+             git clone https://github.com/PinguinoIDE/pinguino-compilers; \
+           fi; \
+           p32-gcc --version; \
+           ")
+path+=("$prebuilt/pinguino-compilers/linux64/p32/bin")
+
+# risc-v gcc toolchain
+install+=("if [ ! -d \"$prebuilt/riscv64-unknown-elf-gcc/bin\" ]; then \
+             cd $prebuilt; \
+             wget 
https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14.tar.gz;
 \
+             tar zxf 
riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14.tar.gz; \
+             mv riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14 
riscv64-unknown-elf-gcc; \
+             rm 
riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-linux-ubuntu14.tar.gz; \
+           fi; \
+           riscv64-unknown-elf-gcc --version; \
+           ")
+path+=("$prebuilt/riscv64-unknown-elf-gcc/bin")
+
+# ccache
+install+=("if [ ! -d \"$prebuilt/ccache/bin\" ]; then \
+             cd $prebuilt; \
+             wget 
https://github.com/ccache/ccache/releases/download/v3.7.7/ccache-3.7.7.tar.gz; \
+             tar zxf ccache-3.7.7.tar.gz; \
+             cd ccache-3.7.7; ./configure --prefix=$prebuilt/ccache; make; 
make install; \
+             cd $prebuilt; rm -rf ccache-3.7.7; rm ccache-3.7.7.tar.gz; \
+             ln -sf $prebuilt/ccache/bin/ccache $prebuilt/ccache/bin/gcc; \
+             ln -sf $prebuilt/ccache/bin/ccache $prebuilt/ccache/bin/g++; \
+             ln -sf $prebuilt/ccache/bin/ccache 
$prebuilt/ccache/bin/arm-none-eabi-gcc; \
+             ln -sf $prebuilt/ccache/bin/ccache 
$prebuilt/ccache/bin/arm-none-eabi-g++; \
+             ln -sf $prebuilt/ccache/bin/ccache $prebuilt/ccache/bin/p32-gcc; \
+             ln -sf $prebuilt/ccache/bin/ccache 
$prebuilt/ccache/bin/riscv64-unknown-elf-gcc; \
+             ln -sf $prebuilt/ccache/bin/ccache 
$prebuilt/ccache/bin/riscv64-unknown-elf-g++; \
+           fi; \
+           ccache --version; \
+           export USE_CCACHE=1; \
+           export CCACHE_DIR=$prebuilt/ccache/.ccache; \
+           ccache -M 5G; \
+           ")
+path+=("$prebuilt/ccache/bin")
+
+function usage {
+  echo ""
+  echo "USAGE: $0 check | full"
+  echo "       $0 -h"
+  echo ""
+  echo "Where:"
+  echo "  check:   do check build CI"
+  echo "  full:    do full build CI"
+  echo "  -h will show this help test and terminate"
+  echo ""
+  exit 1
+}
+
+function setup_repos {
+  if [ -d "$nuttx" ]; then
+    cd $nuttx; git pull
+  else
+    git clone https://github.com/apache/incubator-nuttx.git $nuttx
+  fi
+
+  if [ -d "$apps" ]; then
+    cd $apps; git pull
+  else
+    git clone https://github.com/apache/incubator-nuttx-apps.git $apps
+  fi
+}
+
+function install_tools {
+  for ((i=0; i<${#install[@]}; ++i)); do
+    export PATH=${path[$i]}:$PATH
+    eval ${install[$i]}
 
 Review comment:
   Using `eval` on a long strings of code makes difficult to edit (editors will 
not highlight the code inside the literal string). To me it looks like extra 
complexity for no apparent benefit. Why not putting directly the code like in 
`install_tools()` or at least define function for each one, and then call them 
from `install_tools()`?.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to