Hi Xiang, Are the PRs really any efficient if there is someone else doing nxstyle cleanups after each change? The build failures due to obvious misspellings should be corrected *fast*, so I don't want to delay things by going through entire file with nxstyle.
I'm not very keen on this whole Apache stuff and workflows saying how to contribute. I have used PRs for big changes that add new functionality, but don't like that mechanism much. I've actually grown to like the "traditional nuttx" highly unorthodox method of Greg editing incoming patches. Best Regards, Juha ________________________________ From: Xiang Xiao <xiaoxiang781...@gmail.com> Sent: Friday, April 17, 2020 5:29 AM To: dev@nuttx.apache.org <dev@nuttx.apache.org> Subject: Re: [PATCH] nshlib/nsh_codeccmd.c: fix potential NULL dereference and check malloc return values Juha, Since you contribute many code to NuttX and work with NuttX daily, it will be more efficient and collaborative if you can send the patch through github PR. Thanks Xiang On Thu, Apr 16, 2020 at 8:53 PM Alan Carvalho de Assis <acas...@gmail.com> wrote: > > Hi Juha, > > I just created apps PR #183 with your patch. > > Thank you! > > BR, > > Alan > > On 4/16/20, Juha Niskanen (Haltian) <juha.niska...@haltian.com> wrote: > > Hi, > > > > Small thing I found when reading through nsh code. > > > > Best Regards, > > Juha > >
