Haitao, Thanks for catching that. I suspect this might have been around for a while in the zip releases. The release script checks out a tag to make sure we are getting what we expect so I dont think we cut the wrong code
What looks to be going on is we have files in .gitignore that are being stripped when zipme.sh calls tar ./nuttx/tools/zipme.sh:TAR+=" --exclude-vcs-ignores --exclude-vcs" We are also stripping out all the z80 asm files which is really bad. I did a diff between the tag and the release tarball and I found this diff -rq nuttx/ ../incubator-nuttx | grep -v gitignore Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_handlers.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f91_init.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_handlers.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_init.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_loader.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80f92_program.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_getsp.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_io.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqcommon.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_irqsave.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_progentry.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_reset.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_restorecontext.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_saveusercontext.asm Only in ../incubator-nuttx/arch/z80/src/ez80: ez80_startup.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_head.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_restoreusercontext.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_rom.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_romvectors.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_saveusercontext.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectcommon.asm Only in ../incubator-nuttx/arch/z80/src/z180: z180_vectors.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_head.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_restoreusercontext.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_rom.asm Only in ../incubator-nuttx/arch/z80/src/z80: z80_saveusercontext.asm Only in ../incubator-nuttx: .asf.yaml Only in ../incubator-nuttx/boards/arm/samd5e5/metro-m4/scripts: nvm.srec Only in ../incubator-nuttx/boards/arm/samd5e5/same54-xplained-pro/scripts: nvm.srec Only in ../incubator-nuttx/boards/sim/sim/sim/src/etc: init.d Only in ../incubator-nuttx: .git Only in ../incubator-nuttx: .github Only in nuttx/: .version Anyone have a suggestion on how to handle this? I am tempted to remove that option. That would require making sure the repo is clean. I do this anyway by doing a fresh shallow clone of the repo and checking that the tag is exactly matching the commit --Brennan On Fri, Jul 3, 2020 at 7:04 PM Haitao Liu <liugu...@gmail.com> wrote: > > I have just downloaded > https://dist.apache.org/repos/dist/dev/incubator/nuttx/9.1.0-RC1/ and built > sim:nsh which reports rcS missing as below. > But I checked the release/9.1 branch with rcS change inside. So I wonder if > the 9.1.0-RC1 is not align to the latest 9.1 branch code. > > make[1]: Entering directory '/home/haitao/test/nuttx/arch/sim/src' > make[2]: Entering directory '/home/haitao/test/nuttx/boards/sim/sim/sim/src' > make[2]: *** No rule to make target 'etc/init.d/rcS', needed by > 'etctmp/etc/init.d/rcS'. Stop. > make[2]: Leaving directory '/home/haitao/test/nuttx/boards/sim/sim/sim/src' > Makefile:326: recipe for target '.depend' failed > make[1]: *** [.depend] Error 2 > make[1]: Leaving directory '/home/haitao/test/nuttx/arch/sim/src' > tools/Makefile.unix:441: recipe for target 'pass2dep' failed > > Brennan Ashton <bash...@brennanashton.com> 于2020年6月27日周六 上午1:48写道： > > > Hey everyone, > > There were several bugs found on the RC0 so we will not be moving forward > > with that release candidate and will be creating RC1. I had suggested a > > few days ago creating the release today, but as we merged some changes > > yesterday that seems to be rushed. > > > > I'm proposing that we move forward cutting the RC1 on Sunday 28th. I would > > encourage everyone to test with the fixes that have been backported already > > to the releases/9.1 branch. I know there is an outstanding bug report that > > was sent to the list but this is not even in master yet. > > > > > > https://lists.apache.org/x/thread.html/rbb1f85b5f2dba9ee221548fcc5f99d49ef55522c487b99c1549c3a52@%3Cdev.nuttx.apache.org%3E > > > > > > Thanks, > > Brennan > >
