But how long does it take you, when the linker tell you, you have over flowed .text by 256 bytes?
-----Original Message----- From: GitBox [mailto:g...@apache.org] Sent: Thursday, July 30, 2020 12:13 PM To: comm...@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1487: libc: Avoid ctype function to evaluate the argument more than once xiaoxiang781216 commented on a change in pull request #1487: URL: https://github.com/apache/incubator-nuttx/pull/1487#discussion_r463213449 ########## File path: include/ctype.h ########## @@ -65,13 +94,10 @@ #ifdef __cplusplus static inline int isspace(int c) { - return c == ' ' || c == '\t' || c == '\n' || c == '\r' || - c == '\f' || c == '\v'; + return __ctype_lookup(c) & _S; } #else -# define isspace(c) \ - ((c) == ' ' || (c) == '\t' || (c) == '\n' || (c) == '\r' || \ - (c) == '\f' || (c) == '\v') +# define isspace(c) (__ctype_lookup(c) & _S) Review comment: > Linux works the same way. It does not use the standard libc header files. Rather, it is has its own set of header files that are in parallel with the libc header files with alternative definitions for use within the kernel. It is a very standard thing to do within operating systems. We can use the special header file if you like, but the double evaluation must be addressed. Nobody want to spend one/two day to debug this type of error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
