Hi Frank-Christian,

I just submitted a PR to fix the issue you reported:

https://github.com/apache/incubator-nuttx/pull/2120

Please let me know if it works for you.

BR,

Alan

On 10/26/20, Frank-Christian Kruegel <nu...@istda.com> wrote:
> Hello World();
>
> When using the CONFIG_STM32H7_PHYINIT option I get an compile error
> saying that ret ist undefined.
>
> Fix:
>
> --- nuttx-org/arch/arm/src/stm32h7/stm32_ethernet.c    2020-10-26
> 12:09:41.855853749 +0100
> +++ nuttx/arch/arm/src/stm32h7/stm32_ethernet.c    2020-10-26
> 12:12:50.923943167 +0100
> @@ -4421,12 +4421,14 @@
>   #ifdef CONFIG_STM32H7_PHYINIT
>     /* Perform any necessary, board-specific PHY initialization */
>
> -  ret = stm32_phy_boardinitialize(0);
> +  {
> +  int ret = stm32_phy_boardinitialize(intf);
>     if (ret < 0)
>       {
>         nerr("ERROR: Failed to initialize the PHY: %d\n", ret);
>         return ret;
>       }
> +  }
>   #endif
>
>     /* Put the interface in the down state. */
>
> Furthermore, I guess the argument of stm32_phy_boardinitialize() shound
> be the interface id, not a fixed 0.
>
> Please consider this path for the next release.
>
> Frank-Christian
>
>
>

Reply via email to