it will be easier next time.
Does any of the 21 queued test that I see waiting in github enable this
driver?
Because if they dont (which I suspect, hence this typo) these tests are
useless.
Sebastien
Le 25/05/2021 à 16:17, Sebastien Lorquet a écrit :
No, the workflow is very clear, the pull request model is a defacto
standard that works everywhere.
But it is heavy for trivial changes. fork, mess with remotes, make a
branch, forget to change the git config --local user.name, push, deal
with github and my ssh agent messing with multiple ssh keys for
different github users, etc etc and then wait for the CI to build
megabytes of useless tests just for an obvious typo.
It was just easier to send a patch inline and have Greg merge that
immediately. I was never happy with this change and there is no reason
to feel better now. But there is no way back now.Just less
contributions from me.
Sebastien
Le 25/05/2021 à 16:11, Nathan Hartman a écrit :
On Tue, May 25, 2021 at 10:05 AM Sebastien Lorquet
<sebast...@lorquet.fr> wrote:
done, what a process for a 7-character change...
The PHY and cable detection worked perfectly fine in our project.
Sebastien
Thanks so much for doing that!
Regarding the process, did you have any difficulty, i.e., anything
that should be improved in our docs explaining the workflow?
Cheers,
Nathan