On Mon, Oct 18, 2021 at 4:11 AM Gregory Nutt wrote: > > By the way, did anyone since 1998 of genromfs existence notice this > > part of Makefile that may cripple your system files ?! > > > > install-man: > > # genromfs 0.5 installed the man page in this file, > > # remove it before someone notices :) > > if [ -f $(PREFIX)$(bindir)/man8 ]; then \ > > rm -f $(PREFIX)$(bindir)/man8; \ > > fi > > mkdir -p $(PREFIX)$(mandir)/man8 > > install -m 644 genromfs.8 $(PREFIX)$(mandir)/man8/ > > > > Well I noticed that. It will not replace existing file not even delete > > the single file of interest it will delete whole man pages directory > > as part of install !!! Very funny :-( > > > > Are you sure? It looks like it removes the $bindir/man8 which is probably > /usr/local/bin/man8. Then it installs the manpages correctly at > $mandir/man8
Well also $(bindir) is messed with $(mandir). I just removed that part in the patch :-) > That is probably okay. Far from okay to rm -rf anything as root without user knowledge especially at /usr location. Why not rm -rf / right away? :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info
