Hello Jukka,

So you experience the same problem as Daniel and reverting the commit helps?

Before f77956a227f1db6ecb44eda3814e7b02aa2187a6 there was no way to
reuse common code from "nuttx/board/...". I'm using a custom board
based on SAME70 and after
https://github.com/apache/incubator-nuttx/pull/4981 I found my code
tree broken. Now the folder structure for "boards/arm/samv7" is the
same as in "boards/arm/stm32". Here is what I did to get it back
running:
1. Synced "custom-board/scripts/Make.defs" with
"boards/arm/samv7/same70-xplained/scripts/Make.defs"
2. Renamed "custom-board/src/Makefile" to "custom-board/src/Make.defs"
and synced with "boards/arm/samv7/same70-xplained/src/Make.defs"
3. Removed files in my code tree that have exactly the same
implementation as files from "boards/arm/samv7/common"

It seems like Daniel is hitting the same issue, so I expect that
renaming Makefile to Make.defs plus setting "BOARD_STM32_COMMON=n"
should fix the issue without any additional file clean-up.
Please give me feedback if that helps.

Best regards,
Petro

чт, 3 бер. 2022 р. о 07:40 Jukka Laitinen <jukka.laiti...@iki.fi> пише:
>
> HI,
>
> Not sure what is the correct way to fix this, but I reverted:
>
> "
>
> commit f77956a227f1db6ecb44eda3814e7b02aa2187a6
> Author: Petro Karashchenko <petro.karashche...@gmail.com>
> Date:   Wed Jan 19 11:16:11 2022 +0200
>
>      tools: add option to reuse boards common files for custom boards
>
>      Signed-off-by: Petro Karashchenko <petro.karashche...@gmail.com>
> "
>
> Petro, what is the proper way to configure this?
>
> Thanks,
>
> Jukka
>
>
>
> On 3.3.2022 0.06, Daniel Pereira Carvalho wrote:
>
> > Hi guys,
> >
> > I am having problems building custom boards outside of the Nuttx folder
> > tree. Usually I use the following folder structure.
> >
> > |-> apps
> > |-> my-folder
> >     |-> my-apps
> >        |-> custom-app
> >     |-> my-boards
> >        |-> custom-board
> > |-> nuttx
> >
> > To build my apps I just need to create a symbolic link called external
> > inside apps folder. To create a new custom board I start copying a similar
> > board (e.g nucleo-g431kb) to my-boards folder and make the following changes
> >
> > *remove from defconfig:*
> > CONFIG_ARCH_BOARD="nucleo-g431kb"
> > CONFIG_ARCH_BOARD_NUCLEO_G431KB=y
> >
> > *add on defconfig:*
> > CONFIG_ARCH_BOARD_CUSTOM=y
> > CONFIG_ARCH_BOARD_CUSTOM_DIR="../my-folder/my-boards/custom-board"
> > CONFIG_ARCH_BOARD_CUSTOM_DIR_RELPATH=y
> > CONFIG_ARCH_BOARD_CUSTOM_NAME="custom-board"
> >
> > *Rename src/Make.defs to src/Makefile and append the line *
> > include $(TOPDIR)/boards/Board.mk at the end of file.
> >
> > This works well for me up to Nuttx version 10.2.0 but now when I try to
> > make I got the errors
> >
> > make[1]: Entering directory '/home/daniel/nuttx-workspace/nuttx/tools'
> > make[1]: Leaving directory '/home/daniel/nuttx-workspace/nuttx/tools'
> > make[1]: Entering directory '/home/daniel/nuttx-workspace/nuttx/tools'
> > make[1]: Leaving directory '/home/daniel/nuttx-workspace/nuttx/tools'
> > Create version.h
> > make[1]: Entering directory '/home/daniel/nuttx-workspace/nuttx/boards'
> > make[2]: Entering directory
> > '/home/daniel/nuttx-workspace/nuttx/boards/arm/stm32/common'
> > Makefile:23: board/Make.defs: No such file or directory
> > make[2]: *** No rule to make target 'board/Make.defs'.  Stop.
> > make[2]: Leaving directory
> > '/home/daniel/nuttx-workspace/nuttx/boards/arm/stm32/common'
> > make[1]: *** [Makefile:79: context] Error 2
> > make[1]: Leaving directory '/home/daniel/nuttx-workspace/nuttx/boards'
> > make: *** [tools/Unix.mk:425: boards/.context] Error 2
> >
> > Does anyone know how to fix this problem?
> >
> > Thanks
> >
> > Daniel Pereira de Carvalho
> >

Reply via email to