Yes, that is the code I’m referring to.
I’m also going to be looking at adding one or two more PCF GPIO expanders to
the system, not LCD, but they will certainly need to live with the LCD backpack.
I’ll have a look at a PR.
Regards,
Mark
_____________________________
Blog: blog.thepcsite.co.uk
Twitter: @nevynuk
> On 23 Jul 2023, at 20:40, Gregory Nutt <spudan...@gmail.com> wrote:
>
>
>> Ideally, I’d have configured this from the user application. As they are
>> embedded within the board startup I’d have thought they would have been
>> configurable through kconfig.
>
> I assume you are referring to the following in
> boards/arm/rp2040/common/src/rp2040_common_bringup.c:
>
> #ifdef CONFIG_LCD_BACKPACK
> /* slcd:0, i2c:0, rows=2, cols=16 */
>
> ret = board_lcd_backpack_init(0, 0, 2, 16);
> if (ret < 0)
> {
> syslog(LOG_ERR, "Failed to initialize PCF8574 LCD, error
> %d\n", ret);
> return ret;
> return ret;
> }
> #endif
>
> You would want configurable parameters if you:
>
> 1. Had more than one backpack,
> 2. Had a backpack connected to a different I2C, or
> 3. Had a backpack with a different LCD size.
>
> Since the backpack is an add-on and not a part of the base pico-w board, I
> would think those should be configurable... or at least well-documented. You
> should submit a PR. As long as the defaults are {0,0,2,16} then no existing
> configurations would be impacted.
