Hi Alan,

Thank you for looking at our code base and planning to add Documentation,
> that is really important!
>
> NuttX has a long history but our Documentation is still lagging behind, so
> your work will be very beneficial for our community.
>

I'll try my best to contribute some documentation for the various file
systems I look into, and I, in turn, hope they are informative, and more
importantly, correct, as I'm pretty new to the VFS layer of NuttX.


> BTW, why do you think it is wrong, could you please share your thoughts?
>

The problem according to me is on L264...where it's defined as:

#define DIRSEC_BYTENDX(*f*,i) (((i) & DIRSEC_NDXMASK(*fs*)) << 5)

I can't seem to find anything defined as *fs *in the namespace at that
point (used in the fat_findsfnentry
<https://github.com/apache/nuttx/blob/master/fs/fat/fs_fat32dirent.c#L1137>function),
and I was wondering if it was a simple typo or a mistake on my part as it's
code that's quite old, which usually don't have such mistakes due to
extensive testing.

Best Regards,
Saurav

Reply via email to